Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add aggregation operator tests #2724

Merged
merged 3 commits into from
May 30, 2023
Merged

Add aggregation operator tests #2724

merged 3 commits into from
May 30, 2023

Conversation

chilagrow
Copy link
Member

@chilagrow chilagrow commented May 29, 2023 •
edited
Loading

Description

Refs #2679.
Refs #2694.

These are the tests necessary for operators to function in aggregation stages. They are skipped as they are not implemented yet.

Readiness checklist

  • I added/updated unit tests.
  • I added/updated integration/compatibility tests.
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@chilagrow chilagrow mentioned this pull request May 29, 2023
Closed
@chilagrow chilagrow changed the title Add skipped tests Add aggregation operator tests May 29, 2023
@chilagrow chilagrow added the code/chore Code maintenance improvements label May 29, 2023
@codecov
Copy link

codecov bot commented May 29, 2023 •
edited
Loading

Codecov Report

Merging #2724 (bce152d) into main (439ec96) will decrease coverage by 36.87%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #2724       +/-   ##
===========================================
- Coverage   63.04%   26.17%   -36.87%     
===========================================
  Files         441      441               
  Lines       22619    22619               
===========================================
- Hits        14260     5921     -8339     
- Misses       7434    16091     +8657     
+ Partials      925      607      -318

see 145 files with indirect coverage changes

Flag Coverage Δ
integration 4.96% <ø> (-51.54%) ⬇️
mongodb 4.96% <ø> (ø)
pg ?
unit 24.64% <ø> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@chilagrow chilagrow marked this pull request as ready for review May 29, 2023 08:23
@chilagrow chilagrow requested a review from a team as a code owner May 29, 2023 08:23
@chilagrow chilagrow requested review from AlekSi, rumyantseva, a team, w84thesun and noisersup May 29, 2023 08:23
@chilagrow chilagrow enabled auto-merge (squash) May 29, 2023 08:24
noisersup
noisersup previously approved these changes May 29, 2023
View reviewed changes
Copy link
Member

@noisersup noisersup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

rumyantseva
rumyantseva approved these changes May 30, 2023
View reviewed changes
Copy link
Contributor

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice examples!

integration/aggregate_documents_compat_test.go Show resolved Hide resolved
w84thesun
w84thesun approved these changes May 30, 2023
View reviewed changes
Copy link
Contributor

@w84thesun w84thesun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@chilagrow chilagrow merged commit d924c67 into FerretDB:main May 30, 2023
@AlekSi AlekSi added this to the v1.3.0 milestone Jun 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noisersup noisersup noisersup approved these changes

@rumyantseva rumyantseva rumyantseva approved these changes

@w84thesun w84thesun w84thesun approved these changes

@AlekSi AlekSi Awaiting requested review from AlekSi AlekSi is a code owner automatically assigned from FerretDB/leads

Assignees

@chilagrow chilagrow

Labels
code/chore Code maintenance improvements
Projects
Current Engineering
Archived in project
Milestone
v1.3.0
Development

Successfully merging this pull request may close these issues.
5 participants
@chilagrow @w84thesun @rumyantseva @noisersup @AlekSi