Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more consistency to table tests' field names #2717

Merged
merged 2 commits into from
May 30, 2023
Merged

Add more consistency to table tests' field names #2717

merged 2 commits into from
May 30, 2023

Conversation

rumyantseva
Copy link
Contributor

@rumyantseva rumyantseva commented May 26, 2023 •
edited
Loading

Description

Closes #2599.

This is not a full implementation yet, just a couple of quick wins. I renamed variables in a couple of obvious places.

Readiness checklist

  • I added/updated unit tests.
  • I added/updated integration/compatibility tests.
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@rumyantseva rumyantseva added the not ready Issues that are not ready to be worked on; PRs that should skip CI label May 26, 2023
@rumyantseva rumyantseva self-assigned this May 26, 2023
@rumyantseva rumyantseva added code/chore Code maintenance improvements and removed not ready Issues that are not ready to be worked on; PRs that should skip CI labels May 26, 2023
@codecov
Copy link

codecov bot commented May 26, 2023 •
edited
Loading

Codecov Report

Merging #2717 (003ebdf) into main (d924c67) will decrease coverage by 36.85%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #2717       +/-   ##
===========================================
- Coverage   63.04%   26.19%   -36.85%     
===========================================
  Files         441      441               
  Lines       22619    22619               
===========================================
- Hits        14260     5926     -8334     
- Misses       7434    16087     +8653     
+ Partials      925      606      -319

see 145 files with indirect coverage changes

Flag Coverage Δ
integration 4.96% <ø> (-51.54%) ⬇️
mongodb 4.96% <ø> (ø)
pg ?
unit 24.66% <ø> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@rumyantseva rumyantseva marked this pull request as ready for review May 26, 2023 09:22
@rumyantseva rumyantseva requested a review from a team as a code owner May 26, 2023 09:22
@rumyantseva rumyantseva requested review from AlekSi and chilagrow May 26, 2023 09:22
@rumyantseva rumyantseva enabled auto-merge (squash) May 26, 2023 09:22
@rumyantseva rumyantseva requested review from a team, w84thesun and noisersup May 26, 2023 09:22
noisersup
noisersup previously approved these changes May 26, 2023
View reviewed changes
Copy link
Member

@noisersup noisersup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems consistent to me

@mergify
Copy link
Contributor

mergify bot commented May 26, 2023

@rumyantseva this pull request has merge conflicts.

@mergify mergify bot added the conflict PRs that have merge conflicts label May 26, 2023
chilagrow
chilagrow previously approved these changes May 29, 2023
View reviewed changes
@AlekSi AlekSi added this to the Next milestone May 29, 2023
@rumyantseva rumyantseva dismissed stale reviews from chilagrow and noisersup via 003ebdf May 30, 2023 12:01
@mergify mergify bot removed the conflict PRs that have merge conflicts label May 30, 2023
w84thesun
w84thesun approved these changes May 30, 2023
View reviewed changes
Copy link
Contributor

@w84thesun w84thesun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rumyantseva rumyantseva merged commit 978278c into FerretDB:main May 30, 2023
@rumyantseva rumyantseva deleted the issue-2599-tiny-fix branch May 30, 2023 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noisersup noisersup noisersup approved these changes

@w84thesun w84thesun w84thesun approved these changes

@AlekSi AlekSi Awaiting requested review from AlekSi AlekSi is a code owner automatically assigned from FerretDB/leads

@chilagrow chilagrow Awaiting requested review from chilagrow

Assignees

@rumyantseva rumyantseva

Labels
code/chore Code maintenance improvements
Projects
Current Engineering
Archived in project
Milestone
v1.3.0
Development

Successfully merging this pull request may close these issues.

Do check error messages in non-compat integration tests
5 participants
@rumyantseva @w84thesun @chilagrow @noisersup @AlekSi