Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add supported aggregations to the buildInfo output #2716

Merged
merged 10 commits into from
May 30, 2023
Merged

Add supported aggregations to the buildInfo output #2716

merged 10 commits into from
May 30, 2023

Conversation

kropidlowsky
Copy link
Contributor

Description

Closes #2650 .

Add supported aggregations to the buildInfo output.

Readiness checklist

  • I added/updated unit tests.
  • I added/updated integration/compatibility tests.
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@kropidlowsky kropidlowsky requested a review from a team as a code owner May 25, 2023 22:07
@kropidlowsky kropidlowsky requested review from AlekSi and w84thesun May 25, 2023 22:07
@codecov
Copy link

codecov bot commented May 25, 2023 •
edited
Loading

Codecov Report

Merging #2716 (d89bb80) into main (c905be6) will increase coverage by 0.05%.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2716      +/-   ##
==========================================
+ Coverage   26.18%   26.23%   +0.05%     
==========================================
  Files         441      441              
  Lines       22615    22619       +4     
==========================================
+ Hits         5921     5935      +14     
+ Misses      16087    16077      -10     
  Partials      607      607
Impacted Files Coverage Δ
internal/handlers/commoncommands/msg_buildinfo.go 0.00% <0.00%> (ø)

... and 3 files with indirect coverage changes

Flag Coverage Δ
integration 4.96% <0.00%> (-0.01%) ⬇️
mongodb 4.96% <0.00%> (-0.01%) ⬇️
unit 24.70% <0.00%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@AlekSi AlekSi requested review from chilagrow and removed request for w84thesun May 26, 2023 08:39
@AlekSi AlekSi added the code/chore Code maintenance improvements label May 26, 2023
@AlekSi AlekSi added this to the Next milestone May 26, 2023
@AlekSi AlekSi enabled auto-merge (squash) May 26, 2023 08:51
auto-merge was automatically disabled May 27, 2023 10:36

Head branch was pushed to by a user without write access

@kropidlowsky
Copy link
Contributor Author

@AlekSi Thanks! It got aligned with your review. 👌
Additionally I have changed assert.NotEmpty(t, compatibility) into assert.NotNil(t, ferretdbFeatures).

@kropidlowsky kropidlowsky requested a review from AlekSi May 27, 2023 10:43
chilagrow
chilagrow reviewed May 29, 2023
View reviewed changes
Copy link
Member

@chilagrow chilagrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work so far!

integration/commands_administration_test.go Outdated Show resolved Hide resolved
integration/commands_administration_test.go Outdated Show resolved Hide resolved
@kropidlowsky kropidlowsky requested a review from chilagrow May 29, 2023 06:41
@kropidlowsky
Copy link
Contributor Author

@chilagrow Thanks! Updated.

chilagrow
chilagrow reviewed May 29, 2023
View reviewed changes
Copy link
Member

@chilagrow chilagrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the change, I have few comments about the changes made 😄

integration/commands_administration_test.go Outdated Show resolved Hide resolved
integration/commands_administration_test.go Outdated Show resolved Hide resolved
integration/commands_administration_test.go Outdated Show resolved Hide resolved
chilagrow
chilagrow reviewed May 29, 2023
View reviewed changes
Copy link
Member

@chilagrow chilagrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the change, I have few comments about the changes made 😄

@kropidlowsky kropidlowsky requested a review from chilagrow May 29, 2023 19:09
@kropidlowsky
Copy link
Contributor Author

@chilagrow thanks! updated.

chilagrow
chilagrow approved these changes May 29, 2023
View reviewed changes
Copy link
Member

@chilagrow chilagrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work 🤗 Thanks for the contribution!

@AlekSi AlekSi enabled auto-merge (squash) May 30, 2023 03:43
@AlekSi AlekSi merged commit 439ec96 into FerretDB:main May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chilagrow chilagrow chilagrow approved these changes

@AlekSi AlekSi AlekSi approved these changes

Assignees

@kropidlowsky kropidlowsky

Labels
code/chore Code maintenance improvements
Projects
Current Engineering
Archived in project
Milestone
v1.3.0
Development

Successfully merging this pull request may close these issues.

Add supported aggregations to the buildInfo output
3 participants
@kropidlowsky @AlekSi @chilagrow