Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement envtool version command #2714

Merged
merged 6 commits into from
May 26, 2023
Merged

Implement envtool version command #2714

merged 6 commits into from
May 26, 2023

Conversation

jeremyphua
Copy link
Contributor

@jeremyphua jeremyphua commented May 25, 2023

Description

Closes #2684.

Readiness checklist

  • I added/updated unit tests.
  • I added/updated integration/compatibility tests.
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@jeremyphua jeremyphua requested a review from a team as a code owner May 25, 2023 15:54
@CLAassistant
Copy link

CLAassistant commented May 25, 2023

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented May 25, 2023

Codecov Report

Merging #2714 (0312b23) into main (94537f3) will decrease coverage by 36.82%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #2714       +/-   ##
===========================================
- Coverage   63.04%   26.22%   -36.82%     
===========================================
  Files         436      436               
  Lines       22583    22583               
===========================================
- Hits        14237     5923     -8314     
- Misses       7421    16054     +8633     
+ Partials      925      606      -319     

see 143 files with indirect coverage changes

Flag Coverage Δ
integration 4.97% <ø> (-51.52%) ⬇️
mongodb 4.97% <ø> (ø)
pg ?
unit 24.68% <ø> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@rumyantseva rumyantseva added the code/chore Code maintenance improvements label May 25, 2023
Copy link
Contributor

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for clarifying the task and contributing! This approach looks good to me, it's consistent with the other commands we have in envtool.

I tried it on Mac and Windows, and it works.

I left a couple of minor comments.

cmd/envtool/envtool.go Outdated Show resolved Hide resolved
cmd/envtool/envtool.go Show resolved Hide resolved
cmd/envtool/envtool.go Outdated Show resolved Hide resolved
@rumyantseva rumyantseva enabled auto-merge (squash) May 25, 2023 18:28
auto-merge was automatically disabled May 26, 2023 02:01

Head branch was pushed to by a user without write access

@AlekSi AlekSi requested review from rumyantseva and AlekSi and removed request for w84thesun May 26, 2023 13:16
@AlekSi AlekSi added this to the Next milestone May 26, 2023
@AlekSi AlekSi enabled auto-merge (squash) May 26, 2023 13:19
@AlekSi
Copy link
Member

AlekSi commented May 26, 2023

Thank you!

Copy link
Contributor

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@AlekSi AlekSi merged commit 43a4024 into FerretDB:main May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code/chore Code maintenance improvements
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Implement envtool version command
4 participants