-
Notifications
You must be signed in to change notification settings - Fork 409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement envtool version
command
#2714
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2714 +/- ##
===========================================
- Coverage 63.04% 26.22% -36.82%
===========================================
Files 436 436
Lines 22583 22583
===========================================
- Hits 14237 5923 -8314
- Misses 7421 16054 +8633
+ Partials 925 606 -319 see 143 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for clarifying the task and contributing! This approach looks good to me, it's consistent with the other commands we have in envtool
.
I tried it on Mac and Windows, and it works.
I left a couple of minor comments.
Head branch was pushed to by a user without write access
Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot!
Description
Closes #2684.
Readiness checklist
task all
, and it passed.@FerretDB/core
), Labels, Project and project's Sprint fields.