Unify test file names #2709
Merged
Unify test file names #2709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
w84thesun
added
the
not ready
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2709 +/- ##
=======================================
Coverage 26.19% 26.19%
=======================================
Files 441 441
Lines 22619 22619
=======================================
Hits 5926 5926
Misses 16087 16087
Partials 606 606
Flags with carried forward coverage won't be shown. Click here to find out more. |
w84thesun
removed
the
not ready
rumyantseva
previously approved these changes
May 30, 2023
There was a problem hiding this comment.
These changes make total sense!
E.g. if we had TestCountCommand we would want to name the compat test TestCountCommandCompat, so we can run all the count command tests via something like env GOFLAGS='-run=TestCountCommand*' task test-integration-pg, and we don't need to remember at which part of the name Compat is set :)
chilagrow
previously approved these changes
May 30, 2023
noisersup
previously approved these changes
May 30, 2023
|
@w84thesun linter fails |
w84thesun
dismissed stale reviews from noisersup, chilagrow, and rumyantseva
via
d32021b
noisersup
approved these changes
May 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Readiness checklist
task all, and it passed.@FerretDB/core), Labels, Project and project's Sprint fields.