Fix telemetry reporter logging #2707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes FerretDB#2624. Co-authored-by: Chi Fujii <chi.fujii@ferretdb.io> Co-authored-by: Alexey Palazhchenko <alexey.palazhchenko@ferretdb.io>
AlekSi
requested review from
w84thesun,
rumyantseva,
a team,
chilagrow and
noisersup
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2707 +/- ##
=======================================
Coverage 63.03% 63.03%
=======================================
Files 441 441
Lines 22612 22615 +3
=======================================
+ Hits 14253 14256 +3
Misses 7434 7434
Partials 925 925
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
There is another thing to improve, but not in a rush |
chilagrow
previously approved these changes
May 26, 2023
Beacon returns versions with a leading `v`.
AlekSi
dismissed stale reviews from chilagrow, w84thesun, noisersup, and rumyantseva
via
5486ef3
# Conflicts: # internal/handlers/commonerrors/errorcode_string.go # internal/util/telemetry/reporter_test.go
AlekSi
requested review from
w84thesun,
chilagrow,
rumyantseva,
noisersup and
a team
noisersup
approved these changes
May 29, 2023
chilagrow
approved these changes
May 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Backport fixes from 1.2.1 and improve tests.
Readiness checklist
task all, and it passed.@FerretDB/core), Labels, Project and project's Sprint fields.