Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return a better error for authentication problems #2703

Merged
merged 4 commits into from
May 24, 2023
Merged

Return a better error for authentication problems #2703

merged 4 commits into from
May 24, 2023

Conversation

AlekSi
Copy link
Member

@AlekSi AlekSi commented May 24, 2023 •
edited
Loading

Description

Closes #2663.

Readiness checklist

  • I added/updated unit tests.
  • I added/updated integration/compatibility tests.
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@AlekSi AlekSi added the code/chore Code maintenance improvements label May 24, 2023
@AlekSi AlekSi added this to the Next milestone May 24, 2023
@AlekSi AlekSi self-assigned this May 24, 2023
@AlekSi AlekSi added the not ready Issues that are not ready to be worked on; PRs that should skip CI label May 24, 2023
@AlekSi AlekSi removed the not ready Issues that are not ready to be worked on; PRs that should skip CI label May 24, 2023
@codecov
Copy link

codecov bot commented May 24, 2023 •
edited
Loading

Codecov Report

Merging #2703 (2ea3174) into main (6891780) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2703      +/-   ##
==========================================
- Coverage   26.62%   26.61%   -0.02%     
==========================================
  Files         432      432              
  Lines       22243    22256      +13     
==========================================
  Hits         5923     5923              
- Misses      15714    15727      +13     
  Partials      606      606
Impacted Files Coverage Δ
integration/helpers.go 46.69% <0.00%> (ø)
internal/handlers/commonerrors/error.go 0.00% <ø> (ø)
internal/handlers/commonerrors/errorcode_string.go 80.00% <ø> (ø)
internal/handlers/pg/msg_saslstart.go 0.00% <0.00%> (ø)
Flag Coverage Δ
integration 5.04% <0.00%> (-0.01%) ⬇️
mongodb 5.04% <0.00%> (-0.01%) ⬇️
unit 25.06% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@AlekSi AlekSi marked this pull request as ready for review May 24, 2023 11:56
@AlekSi AlekSi requested a review from a team as a code owner May 24, 2023 11:56
@AlekSi AlekSi requested review from rumyantseva and chilagrow May 24, 2023 11:56
@AlekSi AlekSi enabled auto-merge (squash) May 24, 2023 12:12
@AlekSi AlekSi requested review from a team, w84thesun and noisersup May 24, 2023 12:13
rumyantseva
rumyantseva approved these changes May 24, 2023
View reviewed changes
Copy link
Contributor

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable!

@AlekSi AlekSi disabled auto-merge May 24, 2023 12:26
@AlekSi AlekSi merged commit 7a2bc4c into FerretDB:main May 24, 2023
@AlekSi AlekSi deleted the better-error-message branch May 24, 2023 12:27
AlekSi added a commit that referenced this pull request May 24, 2023
@AlekSi
Return a better error for authentication problems (#2703)
83d5ebb 
Closes #2663.
@AlekSi AlekSi modified the milestones: Next, v1.2.1 May 24, 2023
@AlekSi AlekSi modified the milestones: v1.2.1, v1.3.0 Jun 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rumyantseva rumyantseva rumyantseva approved these changes

@chilagrow chilagrow Awaiting requested review from chilagrow chilagrow is a code owner automatically assigned from FerretDB/leads

@w84thesun w84thesun Awaiting requested review from w84thesun w84thesun was automatically assigned from FerretDB/core

@noisersup noisersup Awaiting requested review from noisersup noisersup was automatically assigned from FerretDB/core

Assignees

@AlekSi AlekSi

Labels
code/chore Code maintenance improvements
Projects
Current Engineering
Archived in project
Milestone
v1.3.0
Development

Successfully merging this pull request may close these issues.

Improve authentication documentation
2 participants
@AlekSi @rumyantseva