Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add distinct command errors test #2687

Merged
merged 6 commits into from
May 24, 2023
Merged

Conversation

w84thesun
Copy link
Contributor

@w84thesun w84thesun commented May 22, 2023

Description

Closes #2231.

Readiness checklist

  • I added/updated unit tests.
  • I added/updated integration/compatibility tests.
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@w84thesun w84thesun added the code/chore Code maintenance improvements label May 22, 2023
@w84thesun w84thesun self-assigned this May 22, 2023
@w84thesun w84thesun added this to the Next milestone May 22, 2023
@codecov
Copy link

codecov bot commented May 22, 2023

Codecov Report

Merging #2687 (c3e5d5b) into main (896d530) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2687      +/-   ##
==========================================
- Coverage   62.74%   62.73%   -0.01%     
==========================================
  Files         432      432              
  Lines       22225    22230       +5     
==========================================
+ Hits        13944    13946       +2     
- Misses       7353     7356       +3     
  Partials      928      928              
Impacted Files Coverage Δ
internal/handlers/commonparams/extract_params.go 82.54% <100.00%> (+0.32%) ⬆️

... and 2 files with indirect coverage changes

Flag Coverage Δ
integration 56.06% <100.00%> (-0.01%) ⬇️
mongodb 5.05% <0.00%> (-0.01%) ⬇️
pg 55.97% <100.00%> (-0.01%) ⬇️
unit 25.07% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@w84thesun w84thesun marked this pull request as ready for review May 23, 2023 08:22
@w84thesun w84thesun requested a review from a team as a code owner May 23, 2023 08:22
@w84thesun w84thesun enabled auto-merge (squash) May 23, 2023 08:22
@w84thesun w84thesun requested review from a team and noisersup May 23, 2023 08:22
Copy link
Contributor

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks for adding tests!

Copy link
Member

@noisersup noisersup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@w84thesun w84thesun merged commit 72503d4 into FerretDB:main May 24, 2023
@w84thesun w84thesun deleted the add-distinct-test branch May 24, 2023 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code/chore Code maintenance improvements
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

distinct returns invalid error type
4 participants