Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement SQLite update and delete commands #2674

Merged
merged 20 commits into from
May 22, 2023
Merged

Implement SQLite update and delete commands #2674

merged 20 commits into from
May 22, 2023

Conversation

w84thesun
Copy link
Contributor

Description

Closes #{issue_number}.

Readiness checklist

  • I added/updated unit tests.
  • I added/updated integration/compatibility tests.
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

Dmitry added 3 commits May 19, 2023 12:39
WIP
faa7c54
WIP
db86e34
Merge branch 'main' into implement-sqlite-delete
ffb9d61 
# Conflicts:
#	internal/handlers/sqlite/msg_find.go
@w84thesun w84thesun added the code/chore Code maintenance improvements label May 19, 2023
@w84thesun w84thesun added this to the Next milestone May 19, 2023
@w84thesun w84thesun self-assigned this May 19, 2023
@codecov
Copy link

codecov bot commented May 19, 2023 •
edited
Loading

Codecov Report

Merging #2674 (55e9fc3) into main (faddeeb) will decrease coverage by 0.54%.
The diff coverage is 20.25%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2674      +/-   ##
==========================================
- Coverage   63.19%   62.65%   -0.54%     
==========================================
  Files         432      432              
  Lines       21971    22256     +285     
==========================================
+ Hits        13885    13945      +60     
- Misses       7151     7375     +224     
- Partials      935      936       +1
Impacted Files Coverage Δ
internal/backends/collection.go 0.00% <ø> (ø)
internal/backends/sqlite/collection.go 0.00% <0.00%> (ø)
internal/backends/sqlite/database.go 0.00% <0.00%> (ø)
internal/backends/sqlite/metadata_storage.go 0.00% <ø> (ø)
internal/handlers/common/findandmodify.go 92.65% <0.00%> (ø)
internal/handlers/commonerrors/error.go 80.00% <ø> (ø)
internal/handlers/commonerrors/errorcode_string.go 80.00% <ø> (ø)
internal/handlers/sqlite/msg_delete.go 0.00% <0.00%> (ø)
internal/handlers/sqlite/msg_insert.go 0.00% <0.00%> (ø)
internal/handlers/sqlite/msg_update.go 0.00% <0.00%> (ø)
... and 8 more

... and 2 files with indirect coverage changes

Flag Coverage Δ
integration 55.99% <20.25%> (-0.50%) ⬇️
mongodb 5.04% <0.00%> (+<0.01%) ⬆️
pg 55.90% <20.25%> (-0.50%) ⬇️
unit 25.04% <2.75%> (-0.31%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@AlekSi AlekSi mentioned this pull request May 20, 2023
Closed
9 tasks
@w84thesun w84thesun changed the title Implement SQLite delete command Implement SQLite update and delete commands May 20, 2023
@AlekSi AlekSi marked this pull request as ready for review May 22, 2023 05:52
@AlekSi AlekSi requested review from AlekSi and a team as code owners May 22, 2023 05:52
@AlekSi AlekSi requested a review from chilagrow May 22, 2023 05:52
@AlekSi AlekSi merged commit d07d80b into FerretDB:main May 22, 2023
@w84thesun w84thesun deleted the implement-sqlite-delete branch May 24, 2023 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlekSi AlekSi Awaiting requested review from AlekSi AlekSi is a code owner

@chilagrow chilagrow Awaiting requested review from chilagrow chilagrow is a code owner automatically assigned from FerretDB/leads

Assignees

@w84thesun w84thesun

Labels
code/chore Code maintenance improvements
Projects
Current Engineering
Archived in project
Milestone
v1.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@w84thesun @AlekSi