Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create SQLite directory if needed #2673

Merged
merged 3 commits into from
May 19, 2023
Merged

Create SQLite directory if needed #2673

merged 3 commits into from
May 19, 2023

Conversation

AlekSi
Copy link
Member

@AlekSi AlekSi commented May 19, 2023 •
edited
Loading

Description

That allows more tests to run on CI.

Readiness checklist

  • I added/updated unit tests.
  • I added/updated integration/compatibility tests.
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@AlekSi
Create SQLite directory if needed
2c976ab 
That allows more tests to run on CI.
@AlekSi AlekSi added the code/chore Code maintenance improvements label May 19, 2023
@AlekSi AlekSi added this to the Next milestone May 19, 2023
@AlekSi AlekSi self-assigned this May 19, 2023
@codecov
Copy link

codecov bot commented May 19, 2023 •
edited
Loading

Codecov Report

Merging #2673 (a147c6b) into main (a075023) will decrease coverage by 0.07%.
The diff coverage is 3.12%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2673      +/-   ##
==========================================
- Coverage   63.26%   63.19%   -0.07%     
==========================================
  Files         432      432              
  Lines       21949    21971      +22     
==========================================
  Hits        13885    13885              
- Misses       7129     7151      +22     
  Partials      935      935
Impacted Files Coverage Δ
internal/backends/sqlite/backend.go 0.00% <0.00%> (ø)
internal/backends/sqlite/metadata_storage.go 0.00% <0.00%> (ø)
internal/handlers/registry/sqlite.go 7.14% <0.00%> (-0.55%) ⬇️
internal/handlers/sqlite/msg_find.go 0.00% <0.00%> (ø)
internal/handlers/sqlite/msg_serverstatus.go 0.00% <0.00%> (ø)
internal/handlers/sqlite/sqlite.go 0.00% <ø> (ø)
integration/setup/listener.go 66.66% <100.00%> (ø)

... and 1 file with indirect coverage changes

Flag Coverage Δ
integration 56.45% <3.12%> (-0.06%) ⬇️
mongodb 5.04% <0.00%> (-0.01%) ⬇️
pg 56.36% <3.12%> (-0.06%) ⬇️
unit 25.35% <0.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@AlekSi AlekSi marked this pull request as ready for review May 19, 2023 10:08
@AlekSi AlekSi requested a review from a team as a code owner May 19, 2023 10:08
@AlekSi AlekSi requested review from w84thesun and chilagrow May 19, 2023 10:08
@AlekSi AlekSi enabled auto-merge (squash) May 19, 2023 10:08
@AlekSi AlekSi removed the request for review from chilagrow May 19, 2023 10:08
@AlekSi AlekSi disabled auto-merge May 19, 2023 12:19
@AlekSi AlekSi merged commit faddeeb into FerretDB:main May 19, 2023
@AlekSi AlekSi deleted the sqlite-fixes branch May 19, 2023 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@w84thesun w84thesun w84thesun approved these changes

Assignees

@AlekSi AlekSi

Labels
code/chore Code maintenance improvements
Projects
Current Engineering
Archived in project
Milestone
v1.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@AlekSi @w84thesun