Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document aggregation operations #2672

Merged
merged 14 commits into from
Jun 2, 2023
Merged

Document aggregation operations #2672

merged 14 commits into from
Jun 2, 2023

Conversation

Fashander
Copy link
Member

Description

Closes #2603.

Readiness checklist

  • I added/updated unit tests.
  • I added/updated integration/compatibility tests.
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@Fashander Fashander added the documentation Something user-visible is badly or not documented label May 19, 2023
@Fashander Fashander added this to the Next milestone May 19, 2023
@Fashander Fashander requested a review from a team May 19, 2023 08:30
@Fashander Fashander self-assigned this May 19, 2023
@codecov
Copy link

codecov bot commented May 19, 2023 •
edited
Loading

Codecov Report

Merging #2672 (5b4ddb7) into main (325c19c) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2672   +/-   ##
=======================================
  Coverage   26.11%   26.11%           
=======================================
  Files         441      441           
  Lines       22689    22689           
=======================================
  Hits         5926     5926           
  Misses      16153    16153           
  Partials      610      610
Flag Coverage Δ
integration 4.95% <ø> (ø)
mongodb 4.95% <ø> (ø)
unit 24.58% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@Fashander Fashander added the do not merge PRs that should not be merged label May 19, 2023
@AlekSi AlekSi marked this pull request as draft May 19, 2023 08:42
@Fashander Fashander marked this pull request as ready for review May 19, 2023 10:27
@chilagrow chilagrow added trust PRs that can access Actions secrets and removed trust PRs that can access Actions secrets labels May 22, 2023
chilagrow
chilagrow reviewed May 22, 2023
View reviewed changes
Copy link
Member

@chilagrow chilagrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small comments 🤗

website/docs/aggregation operations/aggregation-pipeline-and-commands.md Outdated Show resolved Hide resolved
website/docs/aggregation operations/_category_.yml Outdated Show resolved Hide resolved
@AlekSi AlekSi modified the milestones: v1.2.0, Next May 22, 2023
Fashander and others added 2 commits May 23, 2023 08:52
rumyantseva
rumyantseva previously approved these changes May 23, 2023
View reviewed changes
Copy link
Contributor

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a great start to aggregation documentation!
I left a few comments, mostly non-critical, so it's up to you to ignore or implement them.

website/static/img/docs/aggregation-stages.jpg Outdated Show resolved Hide resolved
website/docs/aggregation operations/aggregation-stages.md Outdated Show resolved Hide resolved
website/docs/aggregation operations/aggregation-pipeline-and-commands.md Outdated Show resolved Hide resolved
website/docs/aggregation operations/aggregation-stages.md Outdated Show resolved Hide resolved
rumyantseva
rumyantseva reviewed May 23, 2023
View reviewed changes
Copy link
Contributor

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a great start to aggregation documentation!
I left a few comments, mostly non-critical, so it's up to you to ignore or implement them.

@rumyantseva rumyantseva self-requested a review May 23, 2023 11:28
rumyantseva
rumyantseva reviewed May 23, 2023
View reviewed changes
Copy link
Contributor

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I clicked "approve" instead of "comment". I mostly approve, just want to clarify a few questions.

rumyantseva
rumyantseva previously approved these changes May 30, 2023
View reviewed changes
Copy link
Contributor

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some changes in #2693 will affect this PR (or the other way around), but overall looks good to me!

@Fashander Fashander requested a review from rumyantseva May 30, 2023 20:20
@AlekSi AlekSi added trust PRs that can access Actions secrets and removed documentation Something user-visible is badly or not documented labels May 31, 2023
chilagrow
chilagrow previously approved these changes Jun 1, 2023
View reviewed changes
rumyantseva
rumyantseva approved these changes Jun 1, 2023
View reviewed changes
Copy link
Contributor

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@AlekSi AlekSi added documentation Something user-visible is badly or not documented and removed do not merge PRs that should not be merged labels Jun 2, 2023
@AlekSi AlekSi merged commit 4fae741 into FerretDB:main Jun 2, 2023
@Fashander Fashander deleted the document-aggregate-commands branch December 4, 2023 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noisersup noisersup noisersup approved these changes

@chilagrow chilagrow chilagrow approved these changes

@rumyantseva rumyantseva rumyantseva approved these changes

@AlekSi AlekSi AlekSi approved these changes

@ptrfarkas ptrfarkas Awaiting requested review from ptrfarkas ptrfarkas is a code owner

@w84thesun w84thesun Awaiting requested review from w84thesun

Assignees

@Fashander Fashander

Labels
documentation Something user-visible is badly or not documented trust PRs that can access Actions secrets
Projects
Current Engineering
Archived in project
Milestone
v1.3.0
Development

Successfully merging this pull request may close these issues.

Document aggregate command
6 participants
@Fashander @AlekSi @w84thesun @rumyantseva @chilagrow @noisersup