Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run integration tests for sqlite handler #2666

Merged
merged 6 commits into from
May 19, 2023
Merged

Run integration tests for sqlite handler #2666

merged 6 commits into from
May 19, 2023

Conversation

AlekSi
Copy link
Member

@AlekSi AlekSi commented May 18, 2023 •
edited
Loading

They fail for now, but at least they start!

Readiness checklist

  • I added/updated unit tests.
  • I added/updated integration/compatibility tests.
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@AlekSi AlekSi added the code/chore Code maintenance improvements label May 18, 2023
@AlekSi AlekSi added this to the Next milestone May 18, 2023
@AlekSi AlekSi self-assigned this May 18, 2023
@codecov
Copy link

codecov bot commented May 18, 2023 •
edited
Loading

Codecov Report

Merging #2666 (2a6921a) into main (002d375) will decrease coverage by 36.44%.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #2666       +/-   ##
===========================================
- Coverage   63.33%   26.90%   -36.44%     
===========================================
  Files         432      432               
  Lines       21925    21949       +24     
===========================================
- Hits        13887     5906     -7981     
- Misses       7106    15440     +8334     
+ Partials      932      603      -329
Impacted Files Coverage Δ
integration/setup/listener.go 0.00% <0.00%> (-68.26%) ⬇️
integration/setup/setup.go 62.08% <ø> (-1.10%) ⬇️
integration/shareddata/provider.go 38.02% <0.00%> (-41.98%) ⬇️
integration/shareddata/scalars.go 100.00% <ø> (ø)
internal/backends/collection.go 0.00% <0.00%> (ø)
internal/backends/sqlite/collection.go 0.00% <0.00%> (ø)
internal/handlers/hana/msg_setfreemonitoring.go 0.00% <0.00%> (ø)
internal/handlers/registry/sqlite.go 7.69% <0.00%> (-0.65%) ⬇️
...nal/handlers/sqlite/msg_getfreemonitoringstatus.go 0.00% <0.00%> (ø)
internal/handlers/sqlite/msg_insert.go 0.00% <0.00%> (ø)
... and 2 more

... and 137 files with indirect coverage changes

Flag Coverage Δ
integration 5.05% <0.00%> (-51.53%) ⬇️
mongodb 5.05% <0.00%> (-0.01%) ⬇️
pg ?
unit 25.42% <0.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@mergify
Copy link
Contributor

mergify bot commented May 18, 2023

@AlekSi this pull request has merge conflicts.

@mergify mergify bot added the conflict PRs that have merge conflicts label May 18, 2023
@AlekSi
Merge branch 'main' into tests
961262d 
# Conflicts:
#	internal/backends/sqlite/database.go
@mergify mergify bot removed the conflict PRs that have merge conflicts label May 18, 2023
@AlekSi AlekSi marked this pull request as ready for review May 18, 2023 18:32
@AlekSi AlekSi requested a review from a team as a code owner May 18, 2023 18:32
@AlekSi AlekSi requested review from w84thesun and rumyantseva May 18, 2023 18:32
@AlekSi AlekSi enabled auto-merge (squash) May 18, 2023 18:32
@AlekSi AlekSi requested review from chilagrow and removed request for rumyantseva May 18, 2023 18:32
w84thesun
w84thesun approved these changes May 18, 2023
View reviewed changes
Copy link
Contributor

@w84thesun w84thesun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

chilagrow
chilagrow approved these changes May 19, 2023
View reviewed changes
Copy link
Member

@chilagrow chilagrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@AlekSi AlekSi added not ready Issues that are not ready to be worked on; PRs that should skip CI and removed not ready Issues that are not ready to be worked on; PRs that should skip CI labels May 19, 2023
@AlekSi AlekSi merged commit 65982dc into FerretDB:main May 19, 2023
@AlekSi AlekSi deleted the tests branch May 19, 2023 05:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chilagrow chilagrow chilagrow approved these changes

@w84thesun w84thesun w84thesun approved these changes

Assignees

@AlekSi AlekSi

Labels
code/chore Code maintenance improvements
Projects
Current Engineering
Archived in project
Milestone
v1.2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@AlekSi @w84thesun @chilagrow