Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement query request for SQLite backend #2665

Merged
merged 8 commits into from
May 18, 2023
Merged

Implement query request for SQLite backend #2665

merged 8 commits into from
May 18, 2023

Conversation

w84thesun
Copy link
Contributor

@w84thesun w84thesun commented May 18, 2023 •
edited
Loading

Description

Closes #2387.

Readiness checklist

  • I added/updated unit tests.
  • I added/updated integration/compatibility tests.
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@w84thesun w84thesun self-assigned this May 18, 2023
@codecov
Copy link

codecov bot commented May 18, 2023 •
edited
Loading

Codecov Report

Merging #2665 (0275f3f) into main (50862eb) will decrease coverage by 36.89%.
The diff coverage is 0.00%.

❗ Current head 0275f3f differs from pull request most recent head a6ed9e3. Consider uploading reports for the commit a6ed9e3 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #2665       +/-   ##
===========================================
- Coverage   63.79%   26.91%   -36.89%     
===========================================
  Files         431      432        +1     
  Lines       21754    21910      +156     
===========================================
- Hits        13878     5897     -7981     
- Misses       6941    15411     +8470     
+ Partials      935      602      -333
Impacted Files Coverage Δ
internal/backends/collection.go 0.00% <ø> (ø)
internal/backends/sqlite/collection.go 0.00% <0.00%> (ø)
internal/backends/sqlite/database.go 0.00% <0.00%> (ø)
internal/backends/sqlite/metadata_storage.go 0.00% <0.00%> (ø)
internal/backends/sqlite/pool.go 0.00% <0.00%> (ø)
internal/backends/sqlite/query_iterator.go 0.00% <0.00%> (ø)
internal/handlers/sqlite/msg_find.go 0.00% <0.00%> (ø)

... and 140 files with indirect coverage changes

Flag Coverage Δ
integration 5.06% <0.00%> (-51.93%) ⬇️
mongodb 5.06% <0.00%> (-0.04%) ⬇️
pg ?
unit 25.41% <0.00%> (-0.17%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

w84thesun
w84thesun commented May 18, 2023
View reviewed changes
internal/backends/sqlite/query_iterator.go
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried to put it inside util/iterator but got an import cycle error. Maybe there is another place where we can put it? It would be pretty much the same as in pgdb, I guess.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's keep it there for now

Dmitry added 2 commits May 18, 2023 18:44
@w84thesun w84thesun added the code/chore Code maintenance improvements label May 18, 2023
@w84thesun w84thesun added this to the Next milestone May 18, 2023
@w84thesun w84thesun marked this pull request as ready for review May 18, 2023 17:49
@w84thesun w84thesun requested review from AlekSi and a team as code owners May 18, 2023 17:49
@w84thesun w84thesun requested a review from chilagrow May 18, 2023 17:49
AlekSi
AlekSi approved these changes May 18, 2023
View reviewed changes
Copy link
Member

@AlekSi AlekSi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will wait for CI and merge

@AlekSi AlekSi merged commit 4da644d into FerretDB:main May 18, 2023
@w84thesun w84thesun deleted the sqlite-more-commands branch May 24, 2023 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlekSi AlekSi AlekSi approved these changes

@chilagrow chilagrow Awaiting requested review from chilagrow chilagrow is a code owner automatically assigned from FerretDB/leads

Assignees

@w84thesun w84thesun

Labels
code/chore Code maintenance improvements
Projects
Current Engineering
Archived in project
Milestone
v1.2.0
Development

Successfully merging this pull request may close these issues.

Support basic SQLite backend
2 participants
@w84thesun @AlekSi