Aggregation operators refactor #2664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noisersup
added
the
not ready
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2664 +/- ##
==========================================
- Coverage 62.71% 62.67% -0.04%
==========================================
Files 432 435 +3
Lines 22256 22378 +122
==========================================
+ Hits 13958 14026 +68
- Misses 7370 7425 +55
+ Partials 928 927 -1
Flags with carried forward coverage won't be shown. Click here to find out more. |
chilagrow
reviewed
May 19, 2023
noisersup
removed
the
not ready
chilagrow
previously approved these changes
May 24, 2023
internal/handlers/common/aggregations/operators/accumulators/accumulators.go
Show resolved
Hide resolved
rumyantseva
reviewed
May 24, 2023
There was a problem hiding this comment.
As discussed, almost everything is ready.
Things to clarify are:
- we shouldn't use
go genwhere it's not needed and we should delete previously generated files - iterators are still better than slices, so we don't need to keep everything in memory
switch - casewith similar errors
AlekSi
reviewed
May 24, 2023
internal/handlers/common/aggregations/operators/operators_error.go
Outdated
Show resolved
Hide resolved
w84thesun
reviewed
May 24, 2023
w84thesun
reviewed
May 24, 2023
AlekSi
reviewed
May 24, 2023
|
|
||
| // Error implements the error interface. | ||
| func (e *OperatorError) Error() string { | ||
| return fmt.Sprint(e.code) |
There was a problem hiding this comment.
I think using stringer and error names instead of error code will make things much simpler
There was a problem hiding this comment.
To simplify it as much as possible can't we just do:
var (
// ErrWrongType indicates that operator field is not a document.
ErrWrongType = fmt.Errorf("Invalid type of operator field (expected document)")
// ErrEmptyField indicates that operator field does not specify any operator.
ErrEmptyField = fmt.Errorf("The operator field is empty (expected document)")
// ErrTooManyFields indicates that operator field specifes more than one operators.
ErrTooManyFields = fmt.Errorf("The operator field specifies more than one operator")
// ErrNotImplemented indicates that given operator is not implemented yet.
ErrNotImplemented = fmt.Errorf("The operator is not implemented yet")
)
There was a problem hiding this comment.
Yes, but then exhaustive linter will not be able to help you
There was a problem hiding this comment.
Exactly. It will never complain, even if you remove some cases
There was a problem hiding this comment.
I see, should I replace it with stringer? Also, we use similar logic in pgdb, regex, hanadb, and commonparams should it be replaced either?
There was a problem hiding this comment.
That depends on whatever the switch on those values should be exhaustive
|
@noisersup this pull request has merge conflicts. |
Co-authored-by: Dmitry <dmitry.eremenko@ferretdb.io>
w84thesun
approved these changes
May 24, 2023
rumyantseva
approved these changes
May 24, 2023
chilagrow
approved these changes
May 25, 2023
chilagrow
approved these changes
May 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #2317.
Readiness checklist
task all, and it passed.@FerretDB/core), Labels, Project and project's Sprint fields.