Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add basic observability into backend interfaces #2661

Merged
merged 4 commits into from
May 18, 2023
Merged

Add basic observability into backend interfaces #2661

merged 4 commits into from
May 18, 2023

Conversation

AlekSi
Copy link
Member

@AlekSi AlekSi commented May 18, 2023 •
edited
Loading

Description

Closes #2387.

Readiness checklist

  • I added/updated unit tests.
  • I added/updated integration/compatibility tests.
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@AlekSi AlekSi added code/chore Code maintenance improvements not ready Issues that are not ready to be worked on; PRs that should skip CI labels May 18, 2023
@AlekSi AlekSi added this to the Next milestone May 18, 2023
@AlekSi AlekSi self-assigned this May 18, 2023
@AlekSi AlekSi removed the not ready Issues that are not ready to be worked on; PRs that should skip CI label May 18, 2023
@AlekSi AlekSi marked this pull request as ready for review May 18, 2023 10:46
@AlekSi AlekSi requested a review from a team as a code owner May 18, 2023 10:46
@AlekSi AlekSi requested review from w84thesun and rumyantseva May 18, 2023 10:46
@AlekSi AlekSi enabled auto-merge (squash) May 18, 2023 10:46
@AlekSi AlekSi removed the request for review from rumyantseva May 18, 2023 10:46
w84thesun
w84thesun approved these changes May 18, 2023
View reviewed changes
Copy link
Contributor

@w84thesun w84thesun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@codecov
Copy link

codecov bot commented May 18, 2023 •
edited
Loading

Codecov Report

Merging #2661 (836da47) into main (43be3d2) will decrease coverage by 0.18%.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2661      +/-   ##
==========================================
- Coverage   65.19%   65.02%   -0.18%     
==========================================
  Files         428      429       +1     
  Lines       21297    21343      +46     
==========================================
- Hits        13885    13878       -7     
- Misses       6477     6530      +53     
  Partials      935      935
Impacted Files Coverage Δ
internal/backends/backend.go 0.00% <0.00%> (ø)
internal/backends/collection.go 0.00% <0.00%> (ø)
internal/backends/database.go 0.00% <0.00%> (ø)
internal/backends/sqlite/backend.go 0.00% <0.00%> (ø)
internal/backends/sqlite/database.go 0.00% <0.00%> (ø)
internal/clientconn/conninfo/conn_info.go 93.75% <ø> (-0.19%) ⬇️
internal/clientconn/cursor/cursor.go 0.00% <ø> (ø)
internal/handlers/pg/pgdb/query_iterator.go 83.33% <ø> (-0.31%) ⬇️
internal/handlers/sqlite/msg_create.go 0.00% <0.00%> (ø)
internal/handlers/sqlite/msg_drop.go 0.00% <0.00%> (ø)
... and 8 more

... and 1 file with indirect coverage changes

Flag Coverage Δ
integration 58.09% <0.00%> (-0.20%) ⬇️
mongodb 5.19% <0.00%> (-0.02%) ⬇️
pg 58.00% <0.00%> (-0.20%) ⬇️
unit 26.10% <0.00%> (-0.12%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@AlekSi AlekSi disabled auto-merge May 18, 2023 11:39
@AlekSi AlekSi merged commit acba50c into FerretDB:main May 18, 2023
@AlekSi AlekSi deleted the observability branch May 18, 2023 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@w84thesun w84thesun w84thesun approved these changes

Assignees

@AlekSi AlekSi

Labels
code/chore Code maintenance improvements
Projects
Current Engineering
Archived in project
Milestone
v1.2.0
Development

Successfully merging this pull request may close these issues.

Support basic SQLite backend
2 participants
@AlekSi @w84thesun