Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test case for read in envtools #2657

Merged
merged 7 commits into from
May 18, 2023

Conversation

wqhhust
Copy link
Contributor

@wqhhust wqhhust commented May 17, 2023

Description

Closes #2615.

Readiness checklist

  • I added/updated unit tests.
  • I added/updated integration/compatibility tests.
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@wqhhust wqhhust requested a review from a team as a code owner May 17, 2023 22:19
@wqhhust wqhhust requested review from rumyantseva and chilagrow May 17, 2023 22:19
@codecov
Copy link

codecov bot commented May 17, 2023

Codecov Report

Merging #2657 (7cfbfa0) into main (4da644d) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2657   +/-   ##
=======================================
  Coverage   63.29%   63.29%           
=======================================
  Files         432      432           
  Lines       21925    21925           
=======================================
  Hits        13878    13878           
  Misses       7112     7112           
  Partials      935      935           

see 1 file with indirect coverage changes

Flag Coverage Δ
integration 56.54% <ø> (ø)
mongodb 5.05% <ø> (ø)
pg 56.45% <ø> (ø)
unit 25.39% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Member

@chilagrow chilagrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the test! Just have a minor comment

cmd/envtool/envtool_test.go Outdated Show resolved Hide resolved
@chilagrow
Copy link
Member

Also could you select what you've done on Readiness checklist in #2657 (comment) please 🙏

@wqhhust wqhhust requested a review from chilagrow May 18, 2023 07:09
@chilagrow chilagrow added the code/chore Code maintenance improvements label May 18, 2023
@chilagrow chilagrow requested review from a team, w84thesun and noisersup May 18, 2023 08:18
Copy link
Member

@chilagrow chilagrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution again!

@chilagrow chilagrow enabled auto-merge (squash) May 18, 2023 08:20
Copy link
Member

@noisersup noisersup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chilagrow chilagrow merged commit 002d375 into FerretDB:main May 18, 2023
@AlekSi AlekSi added this to the v1.2.0 milestone May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code/chore Code maintenance improvements
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Implement envtool shell read subcommand
4 participants