Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement metadata storage #2656

Merged
merged 41 commits into from
May 18, 2023
Merged

Conversation

w84thesun
Copy link
Contributor

@w84thesun w84thesun commented May 17, 2023

Description

Closes #2387.

Readiness checklist

  • I added/updated unit tests.
  • I added/updated integration/compatibility tests.
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

Dmitry added 15 commits May 16, 2023 12:04
# Conflicts:
#	internal/backends/sqlite/backend.go
#	internal/backends/sqlite/database.go
#	internal/handlers/sqlite/msg_ismaster.go
#	internal/handlers/sqlite/msg_listcollections.go
#	internal/handlers/sqlite/msg_listdatabases.go
@w84thesun w84thesun self-assigned this May 17, 2023
@w84thesun w84thesun added the code/chore Code maintenance improvements label May 17, 2023
@w84thesun w84thesun added this to the Next milestone May 17, 2023
@w84thesun w84thesun marked this pull request as ready for review May 17, 2023 17:48
@w84thesun w84thesun requested review from AlekSi and a team as code owners May 17, 2023 17:48
@w84thesun w84thesun requested a review from chilagrow May 17, 2023 17:48
@codecov
Copy link

codecov bot commented May 17, 2023

Codecov Report

Merging #2656 (d5dfd5c) into main (acba50c) will decrease coverage by 1.21%.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2656      +/-   ##
==========================================
- Coverage   65.02%   63.81%   -1.21%     
==========================================
  Files         429      431       +2     
  Lines       21343    21746     +403     
==========================================
- Hits        13879    13878       -1     
- Misses       6532     6933     +401     
- Partials      932      935       +3     
Impacted Files Coverage Δ
internal/backends/collection.go 0.00% <ø> (ø)
internal/backends/sqlite/backend.go 0.00% <0.00%> (ø)
internal/backends/sqlite/collection.go 0.00% <0.00%> (ø)
internal/backends/sqlite/database.go 0.00% <0.00%> (ø)
internal/backends/sqlite/metadata_storage.go 0.00% <0.00%> (ø)
internal/backends/sqlite/pool.go 0.00% <0.00%> (ø)
internal/handlers/sqlite/msg_insert.go 0.00% <0.00%> (ø)
internal/handlers/sqlite/msg_listdatabases.go 0.00% <0.00%> (ø)
internal/handlers/sqlite/sqlite.go 0.00% <0.00%> (ø)

... and 6 files with indirect coverage changes

Flag Coverage Δ
integration 57.05% <0.00%> (-1.10%) ⬇️
mongodb 5.09% <0.00%> (-0.10%) ⬇️
pg 56.96% <0.00%> (-1.10%) ⬇️
unit 25.65% <0.00%> (-0.47%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@w84thesun w84thesun removed the request for review from chilagrow May 17, 2023 18:04
@w84thesun w84thesun marked this pull request as draft May 17, 2023 18:04
Dmitry added 2 commits May 17, 2023 19:10
@w84thesun w84thesun added the not ready Issues that are not ready to be worked on; PRs that should skip CI label May 17, 2023
@w84thesun w84thesun marked this pull request as ready for review May 18, 2023 11:56
@w84thesun w84thesun removed the not ready Issues that are not ready to be worked on; PRs that should skip CI label May 18, 2023
@w84thesun w84thesun enabled auto-merge (squash) May 18, 2023 11:58
internal/backends/collection.go Outdated Show resolved Hide resolved
internal/handlers/common/insert.go Outdated Show resolved Hide resolved
@w84thesun w84thesun requested a review from AlekSi May 18, 2023 12:49
@AlekSi AlekSi disabled auto-merge May 18, 2023 13:55
@AlekSi AlekSi merged commit a32335b into FerretDB:main May 18, 2023
@w84thesun w84thesun deleted the implement-metadata-storage branch May 24, 2023 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code/chore Code maintenance improvements
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Support basic SQLite backend
2 participants