Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement some SQLite backend commands #2655

Merged
merged 6 commits into from
May 17, 2023
Merged

Implement some SQLite backend commands #2655

merged 6 commits into from
May 17, 2023

Conversation

AlekSi
Copy link
Member

@AlekSi AlekSi commented May 17, 2023 •
edited
Loading

Description

  • create
  • drop
  • dropDatabase
  • hello
  • isMaster
  • listCollections
  • listDatabases
  • ping

Closes #2387.

Readiness checklist

  • I added/updated unit tests.
  • I added/updated integration/compatibility tests.
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@AlekSi AlekSi added the code/chore Code maintenance improvements label May 17, 2023
@AlekSi AlekSi added this to the Next milestone May 17, 2023
@AlekSi AlekSi self-assigned this May 17, 2023
@AlekSi AlekSi marked this pull request as ready for review May 17, 2023 16:55
@AlekSi AlekSi requested a review from a team as a code owner May 17, 2023 16:55
@AlekSi AlekSi requested review from w84thesun and rumyantseva May 17, 2023 16:55
@AlekSi AlekSi enabled auto-merge (squash) May 17, 2023 16:55
@codecov
Copy link

codecov bot commented May 17, 2023 •
edited
Loading

Codecov Report

Merging #2655 (891987a) into main (5ed655b) will decrease coverage by 38.47%.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #2655       +/-   ##
===========================================
- Coverage   66.19%   27.73%   -38.47%     
===========================================
  Files         429      429               
  Lines       20954    21283      +329     
===========================================
- Hits        13870     5902     -7968     
- Misses       6150    14779     +8629     
+ Partials      934      602      -332
Impacted Files Coverage Δ
internal/backends/backend.go 0.00% <0.00%> (ø)
internal/backends/database.go 0.00% <0.00%> (ø)
internal/backends/error.go 18.42% <0.00%> (-4.92%) ⬇️
internal/backends/errorcode_string.go 50.00% <ø> (ø)
internal/backends/sqlite/backend.go 0.00% <0.00%> (ø)
internal/backends/sqlite/collection.go 0.00% <0.00%> (ø)
internal/backends/sqlite/database.go 0.00% <0.00%> (ø)
internal/handlers/hana/cmd_query.go 0.00% <0.00%> (ø)
internal/handlers/pg/msg_hello.go 0.00% <0.00%> (-100.00%) ⬇️
internal/handlers/pg/msg_ismaster.go 0.00% <0.00%> (-100.00%) ⬇️
... and 12 more

... and 138 files with indirect coverage changes

Flag Coverage Δ
integration 5.21% <0.00%> (-53.93%) ⬇️
mongodb 5.21% <0.00%> (-0.09%) ⬇️
pg ?
unit 26.21% <0.00%> (-0.44%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

w84thesun
w84thesun reviewed May 17, 2023
View reviewed changes
Copy link
Contributor

@w84thesun w84thesun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, only the linter fails with formatting errors in a few places

@w84thesun w84thesun self-requested a review May 17, 2023 17:02
w84thesun
w84thesun approved these changes May 17, 2023
View reviewed changes
Copy link
Contributor

@w84thesun w84thesun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

rumyantseva
rumyantseva approved these changes May 17, 2023
View reviewed changes
Copy link
Contributor

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@AlekSi AlekSi merged commit 749aee0 into FerretDB:main May 17, 2023
@AlekSi AlekSi deleted the some-commands branch May 17, 2023 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rumyantseva rumyantseva rumyantseva approved these changes

@w84thesun w84thesun w84thesun approved these changes

Assignees

@AlekSi AlekSi

Labels
code/chore Code maintenance improvements
Projects
Current Engineering
Archived in project
Milestone
v1.2.0
Development

Successfully merging this pull request may close these issues.

Support basic SQLite backend
3 participants
@AlekSi @w84thesun @rumyantseva