Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix reporting of updates availability #2653

Merged
merged 25 commits into from
May 24, 2023
Merged

Fix reporting of updates availability #2653

merged 25 commits into from
May 24, 2023

Conversation

rumyantseva
Copy link
Contributor

@rumyantseva rumyantseva commented May 17, 2023 •
edited
Loading

Description

Closes #2624.

Readiness checklist

  • I added/updated unit tests.
  • I added/updated integration/compatibility tests.
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@rumyantseva rumyantseva self-assigned this May 17, 2023
@rumyantseva rumyantseva added the code/bug Some user-visible feature works incorrectly label May 17, 2023
@codecov
Copy link

codecov bot commented May 17, 2023 •
edited
Loading

Codecov Report

Merging #2653 (599da1b) into main (fef76e1) will increase coverage by 0.01%.
The diff coverage is 69.76%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2653      +/-   ##
==========================================
+ Coverage   62.73%   62.75%   +0.01%     
==========================================
  Files         432      432              
  Lines       22236    22243       +7     
==========================================
+ Hits        13950    13958       +8     
+ Misses       7358     7357       -1     
  Partials      928      928
Impacted Files Coverage Δ
internal/handlers/tigris/msg_getlog.go 0.00% <0.00%> (ø)
internal/handlers/tigris/tigris.go 0.00% <0.00%> (ø)
internal/handlers/tigris/tigrisdb/tigrisdb.go 41.17% <33.33%> (-4.98%) ⬇️
internal/handlers/pg/msg_getlog.go 81.30% <50.00%> (+0.17%) ⬆️
internal/handlers/common/setfreemonitoring.go 65.38% <85.71%> (+4.51%) ⬆️
ferretdb/ferretdb.go 83.65% <100.00%> (ø)
internal/util/state/metrics.go 100.00% <100.00%> (ø)
internal/util/state/state.go 100.00% <100.00%> (ø)
internal/util/telemetry/reporter.go 43.02% <100.00%> (ø)
Flag Coverage Δ
integration 56.10% <54.05%> (+0.04%) ⬆️
mongodb 5.05% <0.00%> (-0.01%) ⬇️
pg 56.01% <54.05%> (+0.04%) ⬆️
unit 25.09% <53.48%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@rumyantseva rumyantseva marked this pull request as ready for review May 17, 2023 19:07
@rumyantseva rumyantseva requested a review from a team as a code owner May 17, 2023 19:07
@rumyantseva rumyantseva requested review from AlekSi and w84thesun May 17, 2023 19:07
@rumyantseva rumyantseva enabled auto-merge (squash) May 17, 2023 19:07
@rumyantseva rumyantseva requested review from a team, chilagrow and noisersup May 17, 2023 19:07
chilagrow
chilagrow previously approved these changes May 18, 2023
View reviewed changes
Copy link
Member

@chilagrow chilagrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

AlekSi
AlekSi reviewed May 18, 2023
View reviewed changes
internal/util/state/state.go Outdated Show resolved Hide resolved
internal/util/state/state.go Outdated Show resolved Hide resolved
internal/util/telemetry/reporter.go Outdated Show resolved Hide resolved
internal/util/telemetry/reporter.go Outdated Show resolved Hide resolved
internal/util/telemetry/reporter_test.go Outdated Show resolved Hide resolved
@rumyantseva rumyantseva requested review from AlekSi and chilagrow May 19, 2023 07:57
AlekSi
AlekSi requested changes May 19, 2023
View reviewed changes
internal/util/state/state.go Outdated Show resolved Hide resolved
internal/util/state/state.go Outdated Show resolved Hide resolved
internal/util/telemetry/reporter.go Outdated Show resolved Hide resolved
rumyantseva and others added 7 commits May 19, 2023 11:05
@rumyantseva @AlekSi
Update internal/util/state/state.go
a624650 
Co-authored-by: Alexey Palazhchenko <alexey.palazhchenko@gmail.com>
@rumyantseva @AlekSi
Update internal/util/state/state.go
c49d41a 
Co-authored-by: Alexey Palazhchenko <alexey.palazhchenko@gmail.com>
@rumyantseva
wip
5a6d353
@rumyantseva
Merge branch 'issue-2624-update-available' of https://github.com/rumy…
709a674 
…antseva/FerretDB into issue-2624-update-available
@rumyantseva
wip
06f2437
@rumyantseva
wip
6a1e44d
@rumyantseva
wip
ee5982f
@rumyantseva rumyantseva requested a review from AlekSi May 19, 2023 12:30
noisersup
noisersup previously approved these changes May 19, 2023
View reviewed changes
Copy link
Member

@noisersup noisersup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! I like the helper functions for enabling/disabling telemetry.

chilagrow
chilagrow previously approved these changes May 22, 2023
View reviewed changes
@AlekSi AlekSi added the not ready Issues that are not ready to be worked on; PRs that should skip CI label May 24, 2023
@AlekSi AlekSi dismissed stale reviews from noisersup and chilagrow via c33c88a May 24, 2023 10:28
@AlekSi AlekSi removed the not ready Issues that are not ready to be worked on; PRs that should skip CI label May 24, 2023
@AlekSi AlekSi added this to the Next milestone May 24, 2023
w84thesun
w84thesun approved these changes May 24, 2023
View reviewed changes
Copy link
Contributor

@w84thesun w84thesun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlekSi AlekSi disabled auto-merge May 24, 2023 11:50
@AlekSi AlekSi merged commit 77f1690 into FerretDB:main May 24, 2023
AlekSi added a commit that referenced this pull request May 24, 2023
@chilagrow @AlekSi
Fix reporting of updates availability (#2653)
1fc0313 
Closes #2624.

Co-authored-by: Chi Fujii <chi.fujii@ferretdb.io>
Co-authored-by: Alexey Palazhchenko <alexey.palazhchenko@ferretdb.io>
@AlekSi AlekSi modified the milestones: Next, v1.2.1 May 24, 2023
@AlekSi AlekSi modified the milestones: v1.2.1, v1.3.0 Jun 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@w84thesun w84thesun w84thesun approved these changes

@noisersup noisersup noisersup left review comments

@chilagrow chilagrow chilagrow left review comments

@AlekSi AlekSi Awaiting requested review from AlekSi

Assignees

@rumyantseva rumyantseva

Labels
code/bug Some user-visible feature works incorrectly
Projects
Current Engineering
Archived in project
Milestone
v1.3.0
Development

Successfully merging this pull request may close these issues.

Information about available updates is reported incorrectly
5 participants
@rumyantseva @AlekSi @w84thesun @chilagrow @noisersup