Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SQLite handler flags #2651

Merged
merged 2 commits into from
May 17, 2023
Merged

Add SQLite handler flags #2651

merged 2 commits into from
May 17, 2023

Conversation

AlekSi
Copy link
Member

@AlekSi AlekSi commented May 17, 2023

Description

Closes #2387.

Readiness checklist

  • I added/updated unit tests.
  • I added/updated integration/compatibility tests.
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@AlekSi AlekSi added the code/chore Code maintenance improvements label May 17, 2023
@AlekSi AlekSi added this to the Next milestone May 17, 2023
@AlekSi AlekSi self-assigned this May 17, 2023
@codecov
Copy link

codecov bot commented May 17, 2023

Codecov Report

Merging #2651 (5cbc743) into main (a7c6d24) will decrease coverage by 0.04%.
The diff coverage is 30.95%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2651      +/-   ##
==========================================
- Coverage   66.22%   66.19%   -0.04%     
==========================================
  Files         429      429              
  Lines       20930    20954      +24     
==========================================
+ Hits        13861    13870       +9     
- Misses       6135     6150      +15     
  Partials      934      934              
Impacted Files Coverage Δ
internal/backends/sqlite/backend.go 0.00% <0.00%> (ø)
internal/handlers/common/update_array_operators.go 84.22% <ø> (ø)
internal/handlers/registry/sqlite.go 8.33% <0.00%> (-8.34%) ⬇️
internal/handlers/sqlite/sqlite.go 0.00% <0.00%> (ø)
internal/types/expression.go 95.49% <ø> (ø)
...rnal/handlers/common/aggregations/stages/stages.go 29.03% <33.33%> (+9.03%) ⬆️
internal/handlers/registry/registry.go 55.55% <75.00%> (+1.70%) ⬆️
ferretdb/ferretdb.go 83.65% <100.00%> (+0.32%) ⬆️

... and 1 file with indirect coverage changes

Flag Coverage Δ
integration 59.14% <11.90%> (-0.05%) ⬇️
mongodb 5.29% <0.00%> (-0.01%) ⬇️
pg 59.05% <11.90%> (-0.05%) ⬇️
unit 26.65% <19.04%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@AlekSi AlekSi marked this pull request as ready for review May 17, 2023 09:18
@AlekSi AlekSi requested review from ptrfarkas and a team as code owners May 17, 2023 09:18
@AlekSi AlekSi requested review from w84thesun and rumyantseva and removed request for rumyantseva May 17, 2023 09:18
@w84thesun w84thesun enabled auto-merge (squash) May 17, 2023 09:32
Copy link
Contributor

@w84thesun w84thesun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@AlekSi AlekSi disabled auto-merge May 17, 2023 09:33
@AlekSi AlekSi merged commit c067537 into FerretDB:main May 17, 2023
@AlekSi AlekSi deleted the basic-backend branch May 17, 2023 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code/chore Code maintenance improvements
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Support basic SQLite backend
2 participants