-
Notifications
You must be signed in to change notification settings - Fork 410
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Return command error from findAndModify
#2646
Return command error from findAndModify
#2646
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2646 +/- ##
===========================================
- Coverage 63.19% 26.92% -36.27%
===========================================
Files 432 432
Lines 21971 21958 -13
===========================================
- Hits 13885 5913 -7972
- Misses 7151 15441 +8290
+ Partials 935 604 -331
... and 133 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more. |
@chilagrow this pull request has merge conflicts. |
findAndModify
returns command error
findAndModify
returns command errorfindAndModify
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the changes! There is more consistency here and the tests look very helpful!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Description
Closes #1903.
Readiness checklist
task all
, and it passed.@FerretDB/core
), Labels, Project and project's Sprint fields.