Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Aggregation expression refactor #2644

Merged
merged 10 commits into from
May 18, 2023
Merged

Aggregation expression refactor #2644

merged 10 commits into from
May 18, 2023

Conversation

noisersup
Copy link
Member

@noisersup noisersup commented May 16, 2023 •
edited
Loading

Description

Closes #2652.

Moving expressions to the aggregations package. Removing interface. Some smaller naming changes.

Readiness checklist

  • I added/updated unit tests.
  • I added/updated integration/compatibility tests.
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@noisersup noisersup added the not ready Issues that are not ready to be worked on; PRs that should skip CI label May 16, 2023
@codecov
Copy link

codecov bot commented May 16, 2023 •
edited
Loading

Codecov Report

Merging #2644 (8a24ba6) into main (2716382) will decrease coverage by 37.50%.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #2644       +/-   ##
===========================================
- Coverage   65.21%   27.71%   -37.50%     
===========================================
  Files         429      429               
  Lines       21292    21293        +1     
===========================================
- Hits        13886     5902     -7984     
- Misses       6473    14789     +8316     
+ Partials      933      602      -331
Impacted Files Coverage Δ
...nternal/handlers/common/aggregations/expression.go 0.00% <0.00%> (ø)
.../common/aggregations/expressionerrorcode_string.go 0.00% <ø> (ø)
...rnal/handlers/common/aggregations/operators/sum.go 0.00% <0.00%> (-98.77%) ⬇️
...ernal/handlers/common/aggregations/stages/group.go 0.00% <0.00%> (-87.72%) ⬇️
...rnal/handlers/common/aggregations/stages/unwind.go 0.00% <0.00%> (-82.48%) ⬇️

... and 136 files with indirect coverage changes

Flag Coverage Δ
integration 5.21% <0.00%> (-53.06%) ⬇️
mongodb 5.21% <0.00%> (-0.01%) ⬇️
pg ?
unit 26.21% <0.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@noisersup noisersup added code/chore Code maintenance improvements and removed not ready Issues that are not ready to be worked on; PRs that should skip CI labels May 16, 2023
@noisersup noisersup marked this pull request as ready for review May 16, 2023 16:58
@noisersup noisersup requested a review from a team as a code owner May 16, 2023 16:58
@noisersup noisersup requested review from AlekSi and rumyantseva May 16, 2023 16:58
@noisersup noisersup changed the title Expression refactor Refactor aggregation expression code May 16, 2023
@noisersup noisersup changed the title Refactor aggregation expression code Aggregation expression refactor May 16, 2023
@noisersup noisersup enabled auto-merge (squash) May 16, 2023 16:58
@noisersup noisersup requested review from a team, w84thesun and chilagrow May 16, 2023 17:01
w84thesun
w84thesun previously approved these changes May 16, 2023
View reviewed changes
Copy link
Contributor

@w84thesun w84thesun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

chilagrow
chilagrow reviewed May 17, 2023
View reviewed changes
Copy link
Member

@chilagrow chilagrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, have a few comments 🤗

internal/handlers/common/aggregations/expression.go Show resolved Hide resolved
internal/handlers/common/aggregations/expression.go Show resolved Hide resolved
internal/handlers/common/aggregations/expression.go Show resolved Hide resolved
internal/handlers/common/aggregations/expression.go Outdated Show resolved Hide resolved
internal/handlers/common/aggregations/stages/group.go Show resolved Hide resolved
@mergify
Copy link
Contributor

mergify bot commented May 17, 2023

@noisersup this pull request has merge conflicts.

@mergify mergify bot added the conflict PRs that have merge conflicts label May 17, 2023
rumyantseva
rumyantseva previously approved these changes May 17, 2023
View reviewed changes
Copy link
Contributor

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good to me. Only one comment regarding documentation.

internal/handlers/common/aggregations/expression.go Show resolved Hide resolved
@mergify mergify bot removed the conflict PRs that have merge conflicts label May 17, 2023
rumyantseva
rumyantseva approved these changes May 17, 2023
View reviewed changes
Copy link
Contributor

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

chilagrow
chilagrow approved these changes May 18, 2023
View reviewed changes
Copy link
Member

@chilagrow chilagrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@noisersup noisersup merged commit 1c6136f into FerretDB:main May 18, 2023
@noisersup noisersup deleted the expression-refactor branch May 18, 2023 01:40
@AlekSi AlekSi added this to the v1.2.0 milestone May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chilagrow chilagrow chilagrow approved these changes

@rumyantseva rumyantseva rumyantseva approved these changes

@AlekSi AlekSi Awaiting requested review from AlekSi AlekSi is a code owner automatically assigned from FerretDB/leads

@w84thesun w84thesun Awaiting requested review from w84thesun

Assignees

@noisersup noisersup

Labels
code/chore Code maintenance improvements
Projects
Current Engineering
Archived in project
Milestone
v1.2.0
Development

Successfully merging this pull request may close these issues.

Refactor aggregation expression code
5 participants
@noisersup @w84thesun @rumyantseva @chilagrow @AlekSi