Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return int64 values for dbStats and collStats #2642

Merged
merged 5 commits into from
May 16, 2023
Merged

Return int64 values for dbStats and collStats #2642

merged 5 commits into from
May 16, 2023

Conversation

AlekSi
Copy link
Member

@AlekSi AlekSi commented May 16, 2023 •
edited
Loading

Description

To make them work for large databases and collections.

Readiness checklist

  • I added/updated unit tests.
  • I added/updated integration/compatibility tests.
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@AlekSi
Return int64 values for dbStats and collStats
1f14e0e 
To make them work for large databases and collections.
@AlekSi AlekSi self-assigned this May 16, 2023
@AlekSi AlekSi added the code/bug Some user-visible feature works incorrectly label May 16, 2023
@AlekSi AlekSi added this to the Next milestone May 16, 2023
@codecov
Copy link

codecov bot commented May 16, 2023 •
edited
Loading

Codecov Report

Merging #2642 (993ad70) into main (0e853c9) will decrease coverage by 0.04%.
The diff coverage is 73.68%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2642      +/-   ##
==========================================
- Coverage   65.99%   65.95%   -0.04%     
==========================================
  Files         421      421              
  Lines       20838    20846       +8     
==========================================
- Hits        13753    13750       -3     
- Misses       6153     6165      +12     
+ Partials      932      931       -1
Impacted Files Coverage Δ
internal/handlers/tigris/msg_aggregate.go 0.00% <0.00%> (ø)
internal/handlers/tigris/msg_collstats.go 0.00% <0.00%> (ø)
internal/handlers/tigris/msg_datasize.go 0.00% <0.00%> (ø)
internal/handlers/tigris/msg_explain.go 0.00% <0.00%> (ø)
...l/handlers/common/aggregations/stages/collstats.go 83.92% <100.00%> (ø)
internal/handlers/common/serverstatus.go 87.50% <100.00%> (+1.13%) ⬆️
internal/handlers/pg/msg_aggregate.go 82.37% <100.00%> (ø)
internal/handlers/pg/msg_collstats.go 69.69% <100.00%> (ø)
internal/handlers/pg/msg_dbstats.go 73.68% <100.00%> (ø)
internal/handlers/pg/msg_explain.go 78.87% <100.00%> (+0.61%) ⬆️
... and 1 more

... and 3 files with indirect coverage changes

Flag Coverage Δ
integration 58.99% <73.68%> (+<0.01%) ⬆️
mongodb 5.32% <0.00%> (-0.01%) ⬇️
pg 58.89% <73.68%> (+<0.01%) ⬆️
unit 26.55% <0.00%> (-0.23%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@AlekSi AlekSi marked this pull request as ready for review May 16, 2023 14:54
@AlekSi AlekSi requested a review from a team as a code owner May 16, 2023 14:54
@AlekSi AlekSi requested review from w84thesun and chilagrow May 16, 2023 14:54
@AlekSi AlekSi enabled auto-merge (squash) May 16, 2023 14:54
@AlekSi AlekSi requested review from a team, rumyantseva and noisersup May 16, 2023 14:55
rumyantseva
rumyantseva approved these changes May 16, 2023
View reviewed changes
Copy link
Contributor

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, looks reasonable.

w84thesun
w84thesun approved these changes May 16, 2023
View reviewed changes
Copy link
Contributor

@w84thesun w84thesun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LTGM!

@AlekSi AlekSi merged commit b863106 into FerretDB:main May 16, 2023
@AlekSi AlekSi deleted the fix-stats branch May 16, 2023 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rumyantseva rumyantseva rumyantseva approved these changes

@w84thesun w84thesun w84thesun approved these changes

@chilagrow chilagrow Awaiting requested review from chilagrow chilagrow is a code owner automatically assigned from FerretDB/leads

@noisersup noisersup Awaiting requested review from noisersup noisersup was automatically assigned from FerretDB/core

Assignees

@AlekSi AlekSi

Labels
code/bug Some user-visible feature works incorrectly
Projects
Current Engineering
Archived in project
Milestone
v1.2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@AlekSi @w84thesun @rumyantseva