Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup projection #2641

Merged
merged 5 commits into from
May 16, 2023
Merged

Cleanup projection #2641

merged 5 commits into from
May 16, 2023

Conversation

chilagrow
Copy link
Member

@chilagrow chilagrow commented May 16, 2023 •
edited
Loading

Description

Closes #2430.

Readiness checklist

  • I added/updated unit tests.
  • I added/updated integration/compatibility tests.
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@chilagrow chilagrow added the code/chore Code maintenance improvements label May 16, 2023
@chilagrow chilagrow self-assigned this May 16, 2023
@codecov
Copy link

codecov bot commented May 16, 2023 •
edited
Loading

Codecov Report

Merging #2641 (7204d8a) into main (5b96bd8) will increase coverage by 38.24%.
The diff coverage is 70.00%.

❗ Current head 7204d8a differs from pull request most recent head c457c1c. Consider uploading reports for the commit c457c1c to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #2641       +/-   ##
===========================================
+ Coverage   28.24%   66.48%   +38.24%     
===========================================
  Files         421      421               
  Lines       20846    20812       -34     
===========================================
+ Hits         5887    13836     +7949     
+ Misses      14361     6046     -8315     
- Partials      598      930      +332
Impacted Files Coverage Δ
...andlers/common/aggregations/projection_iterator.go 77.77% <0.00%> (+77.77%) ⬆️
...nal/handlers/common/aggregations/stages/project.go 100.00% <ø> (+100.00%) ⬆️
internal/handlers/common/projection_iterator.go 88.88% <ø> (+88.88%) ⬆️
internal/handlers/commonerrors/error.go 80.00% <ø> (+80.00%) ⬆️
internal/handlers/commonerrors/errorcode_string.go 80.00% <ø> (ø)
internal/handlers/common/projection.go 80.58% <66.66%> (+80.58%) ⬆️
...nternal/handlers/common/aggregations/projection.go 80.00% <83.33%> (+80.00%) ⬆️

... and 135 files with indirect coverage changes

Flag Coverage Δ
integration 59.50% <70.00%> (+54.17%) ⬆️
mongodb 5.33% <0.00%> (+<0.01%) ⬆️
pg 59.41% <70.00%> (?)
unit 26.60% <0.00%> (-0.13%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@chilagrow chilagrow changed the title Cleanup aggregation projection Cleanup projection May 16, 2023
@chilagrow chilagrow marked this pull request as ready for review May 16, 2023 10:51
@chilagrow chilagrow requested a review from a team as a code owner May 16, 2023 10:51
@chilagrow chilagrow requested review from AlekSi, rumyantseva, a team, w84thesun and noisersup May 16, 2023 10:51
@chilagrow chilagrow enabled auto-merge (squash) May 16, 2023 10:51
rumyantseva
rumyantseva approved these changes May 16, 2023
View reviewed changes
Copy link
Contributor

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I like the new approach without internal errors. This looks simpler!

noisersup
noisersup approved these changes May 16, 2023
View reviewed changes
Copy link
Member

@noisersup noisersup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chilagrow chilagrow merged commit 2619638 into FerretDB:main May 16, 2023
@AlekSi AlekSi added this to the v1.2.0 milestone May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noisersup noisersup noisersup approved these changes

@rumyantseva rumyantseva rumyantseva approved these changes

@AlekSi AlekSi Awaiting requested review from AlekSi AlekSi is a code owner automatically assigned from FerretDB/leads

@w84thesun w84thesun Awaiting requested review from w84thesun w84thesun was automatically assigned from FerretDB/core

Assignees

@chilagrow chilagrow

Labels
code/chore Code maintenance improvements
Projects
Current Engineering
Archived in project
Milestone
v1.2.0
Development

Successfully merging this pull request may close these issues.

Support dot notation in query projections
4 participants
@chilagrow @rumyantseva @noisersup @AlekSi