-
Notifications
You must be signed in to change notification settings - Fork 409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix a bug with unset field sorting #2638
Merged
rumyantseva
merged 10 commits into
FerretDB:main
from
rumyantseva:fix-a-bug-with-sorting
May 15, 2023
Merged
Fix a bug with unset field sorting #2638
rumyantseva
merged 10 commits into
FerretDB:main
from
rumyantseva:fix-a-bug-with-sorting
May 15, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rumyantseva
added
the
not ready
Issues that are not ready to be worked on; PRs that should skip CI
label
May 15, 2023
rumyantseva
changed the title
Fix a bug with sorting
Fix a bug with unset field sorting
May 15, 2023
rumyantseva
removed
the
not ready
Issues that are not ready to be worked on; PRs that should skip CI
label
May 15, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2638 +/- ##
=======================================
Coverage 65.99% 65.99%
=======================================
Files 421 421
Lines 20837 20838 +1
=======================================
+ Hits 13752 13753 +1
Misses 6153 6153
Partials 932 932
... and 1 file with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more. |
noisersup
approved these changes
May 15, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch
w84thesun
approved these changes
May 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Readiness checklist
task all
, and it passed.@FerretDB/core
), Labels, Project and project's Sprint fields.