Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a bug with unset field sorting #2638

Merged
merged 10 commits into from
May 15, 2023

Conversation

rumyantseva
Copy link
Contributor

@rumyantseva rumyantseva commented May 15, 2023

Description

  1. Added tests that demonstrated a bug.
  2. Fixed the bug.

Readiness checklist

  • I added/updated unit tests.
  • I added/updated integration/compatibility tests.
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@rumyantseva rumyantseva added the not ready Issues that are not ready to be worked on; PRs that should skip CI label May 15, 2023
@rumyantseva rumyantseva changed the title Fix a bug with sorting Fix a bug with unset field sorting May 15, 2023
@rumyantseva rumyantseva added the code/bug Some user-visible feature works incorrectly label May 15, 2023
@rumyantseva rumyantseva removed the not ready Issues that are not ready to be worked on; PRs that should skip CI label May 15, 2023
@codecov
Copy link

codecov bot commented May 15, 2023

Codecov Report

Merging #2638 (139c86e) into main (93a6eb6) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2638   +/-   ##
=======================================
  Coverage   65.99%   65.99%           
=======================================
  Files         421      421           
  Lines       20837    20838    +1     
=======================================
+ Hits        13752    13753    +1     
  Misses       6153     6153           
  Partials      932      932           
Impacted Files Coverage Δ
internal/handlers/common/sort.go 85.71% <100.00%> (+0.13%) ⬆️

... and 1 file with indirect coverage changes

Flag Coverage Δ
integration 58.98% <100.00%> (+<0.01%) ⬆️
mongodb 5.32% <0.00%> (-0.01%) ⬇️
pg 58.89% <100.00%> (+<0.01%) ⬆️
unit 26.70% <0.00%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@rumyantseva rumyantseva marked this pull request as ready for review May 15, 2023 15:31
@rumyantseva rumyantseva requested a review from a team as a code owner May 15, 2023 15:31
@rumyantseva rumyantseva requested review from AlekSi and w84thesun May 15, 2023 15:31
@rumyantseva rumyantseva enabled auto-merge (squash) May 15, 2023 15:31
@rumyantseva rumyantseva requested review from a team, chilagrow and noisersup May 15, 2023 15:31
Copy link
Member

@noisersup noisersup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch

@rumyantseva rumyantseva merged commit 0e853c9 into FerretDB:main May 15, 2023
@rumyantseva rumyantseva deleted the fix-a-bug-with-sorting branch May 15, 2023 18:28
@AlekSi AlekSi added this to the Next milestone May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code/bug Some user-visible feature works incorrectly
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants