Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for aggregation expressions with dots in $group aggregation stage #2636

Merged
merged 10 commits into from
May 17, 2023
Merged

Add tests for aggregation expressions with dots in $group aggregation stage #2636

merged 10 commits into from
May 17, 2023

Conversation

rumyantseva
Copy link
Contributor

@rumyantseva rumyantseva commented May 15, 2023 •
edited
Loading

Description

Closes #2166.

Readiness checklist

  • I added/updated unit tests.
  • I added/updated integration/compatibility tests.
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@rumyantseva rumyantseva self-assigned this May 15, 2023
@rumyantseva rumyantseva added the code/enhancement Some user-visible feature could work better label May 15, 2023
@codecov
Copy link

codecov bot commented May 15, 2023 •
edited
Loading

Codecov Report

Merging #2636 (ee6472c) into main (c067537) will decrease coverage by 38.03%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #2636       +/-   ##
===========================================
- Coverage   66.19%   28.16%   -38.03%     
===========================================
  Files         429      429               
  Lines       20954    20954               
===========================================
- Hits        13870     5902     -7968     
- Misses       6150    14450     +8300     
+ Partials      934      602      -332

see 140 files with indirect coverage changes

Flag Coverage Δ
integration 5.29% <ø> (-53.90%) ⬇️
mongodb 5.29% <ø> (ø)
pg ?
unit 26.65% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@rumyantseva rumyantseva added the not ready Issues that are not ready to be worked on; PRs that should skip CI label May 15, 2023
@rumyantseva rumyantseva changed the title Support dot notation in $group aggregation stage Support aggregation expressions with dots in $group aggregation stage May 16, 2023
@rumyantseva rumyantseva changed the title Support aggregation expressions with dots in $group aggregation stage Add tests for aggregation expressions with dots in $group aggregation stage May 17, 2023
@rumyantseva rumyantseva added code/chore Code maintenance improvements and removed code/enhancement Some user-visible feature could work better not ready Issues that are not ready to be worked on; PRs that should skip CI labels May 17, 2023
@rumyantseva rumyantseva marked this pull request as ready for review May 17, 2023 13:05
@rumyantseva rumyantseva requested a review from a team as a code owner May 17, 2023 13:05
@rumyantseva rumyantseva requested review from AlekSi and chilagrow May 17, 2023 13:05
@rumyantseva rumyantseva enabled auto-merge (squash) May 17, 2023 13:05
@rumyantseva rumyantseva requested review from a team, w84thesun and noisersup May 17, 2023 13:05
noisersup
noisersup approved these changes May 17, 2023
View reviewed changes
Copy link
Member

@noisersup noisersup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rumyantseva rumyantseva merged commit 5ed655b into FerretDB:main May 17, 2023
@rumyantseva rumyantseva deleted the issue-2166-group-dot-notation branch May 17, 2023 16:06
@AlekSi AlekSi added this to the v1.2.0 milestone May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noisersup noisersup noisersup approved these changes

@w84thesun w84thesun w84thesun approved these changes

@AlekSi AlekSi Awaiting requested review from AlekSi AlekSi is a code owner automatically assigned from FerretDB/leads

@chilagrow chilagrow Awaiting requested review from chilagrow chilagrow is a code owner automatically assigned from FerretDB/leads

Assignees

@rumyantseva rumyantseva

Labels
code/chore Code maintenance improvements
Projects
Current Engineering
Archived in project
Milestone
v1.2.0
Development

Successfully merging this pull request may close these issues.

Check how aggregation expressions work in $group aggregation stage
4 participants
@rumyantseva @w84thesun @noisersup @AlekSi