Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor gitBinaryMaskParam function #2634

Merged
merged 29 commits into from
May 23, 2023
Merged

Refactor gitBinaryMaskParam function #2634

merged 29 commits into from
May 23, 2023

Conversation

w84thesun
Copy link
Contributor

@w84thesun w84thesun commented May 15, 2023 •
edited
Loading

Description

Closes #2465.

Readiness checklist

  • I added/updated unit tests.
  • I added/updated integration/compatibility tests.
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@w84thesun w84thesun added the code/chore Code maintenance improvements label May 15, 2023
@w84thesun w84thesun self-assigned this May 15, 2023
@codecov
Copy link

codecov bot commented May 15, 2023 •
edited
Loading

Codecov Report

Merging #2634 (b04cb3f) into main (f9e8a4d) will decrease coverage by 36.05%.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #2634       +/-   ##
===========================================
- Coverage   62.68%   26.63%   -36.05%     
===========================================
  Files         432      432               
  Lines       22256    22225       -31     
===========================================
- Hits        13951     5920     -8031     
- Misses       7371    15701     +8330     
+ Partials      934      604      -330
Impacted Files Coverage Δ
internal/handlers/common/filter.go 0.00% <0.00%> (-84.50%) ⬇️
internal/handlers/common/params.go 3.45% <0.00%> (-86.48%) ⬇️
internal/handlers/common/sort.go 6.66% <0.00%> (-79.05%) ⬇️
internal/handlers/commonparams/extract_params.go 74.44% <ø> (-7.78%) ⬇️
internal/handlers/commonparams/params.go 53.78% <ø> (-38.66%) ⬇️

... and 135 files with indirect coverage changes

Flag Coverage Δ
integration 5.05% <0.00%> (-50.97%) ⬇️
mongodb 5.05% <0.00%> (+<0.01%) ⬆️
pg ?
unit 25.08% <0.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@w84thesun w84thesun marked this pull request as ready for review May 15, 2023 18:52
@w84thesun w84thesun requested a review from a team as a code owner May 15, 2023 18:52
@w84thesun w84thesun enabled auto-merge (squash) May 15, 2023 18:52
@w84thesun w84thesun requested review from a team and noisersup May 15, 2023 18:52
chilagrow
chilagrow reviewed May 16, 2023
View reviewed changes
Copy link
Member

@chilagrow chilagrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great doc 💪

Just a couple of minor comments 🤗

internal/handlers/commonparams/params.go Outdated Show resolved Hide resolved
internal/handlers/common/params.go Outdated Show resolved Hide resolved
internal/handlers/common/params.go Outdated Show resolved Hide resolved
Dmitry added 3 commits May 16, 2023 08:36
@w84thesun w84thesun requested review from AlekSi and chilagrow May 16, 2023 09:06
rumyantseva
rumyantseva previously approved these changes May 16, 2023
View reviewed changes
chilagrow
chilagrow previously approved these changes May 17, 2023
View reviewed changes
@AlekSi AlekSi added the do not merge PRs that should not be merged label May 17, 2023
@AlekSi AlekSi added the not ready Issues that are not ready to be worked on; PRs that should skip CI label May 18, 2023
@AlekSi AlekSi marked this pull request as draft May 18, 2023 11:44
auto-merge was automatically disabled May 18, 2023 11:44

Pull request was converted to draft

@w84thesun w84thesun dismissed stale reviews from chilagrow and rumyantseva via aea7ad4 May 22, 2023 11:07
@w84thesun w84thesun changed the title Extend parameter parsing functions documentation Refactor gitBinaryMaskParam function May 22, 2023
@w84thesun w84thesun removed not ready Issues that are not ready to be worked on; PRs that should skip CI do not merge PRs that should not be merged labels May 22, 2023
@w84thesun w84thesun marked this pull request as ready for review May 22, 2023 11:36
@w84thesun w84thesun enabled auto-merge (squash) May 22, 2023 11:37
rumyantseva
rumyantseva approved these changes May 22, 2023
View reviewed changes
Copy link
Contributor

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

chilagrow
chilagrow approved these changes May 23, 2023
View reviewed changes
Copy link
Member

@chilagrow chilagrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@w84thesun w84thesun merged commit 896d530 into FerretDB:main May 23, 2023
@w84thesun w84thesun deleted the issue-2465-document-params-functions branch May 23, 2023 01:37
@AlekSi AlekSi added this to the v1.3.0 milestone Jun 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chilagrow chilagrow chilagrow approved these changes

@rumyantseva rumyantseva rumyantseva approved these changes

@noisersup noisersup Awaiting requested review from noisersup noisersup was automatically assigned from FerretDB/core

@AlekSi AlekSi Awaiting requested review from AlekSi

Assignees

@w84thesun w84thesun

Labels
code/chore Code maintenance improvements
Projects
Current Engineering
Archived in project
Milestone
v1.3.0
Development

Successfully merging this pull request may close these issues.

Refactor how we process handlers params
4 participants
@w84thesun @AlekSi @rumyantseva @chilagrow