Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement envtool shell read subcommand #2626

Merged
merged 12 commits into from
May 16, 2023
Merged

Implement envtool shell read subcommand #2626

merged 12 commits into from
May 16, 2023

Conversation

wqhhust
Copy link
Contributor

@wqhhust wqhhust commented May 13, 2023 •
edited by rumyantseva
Loading

Description

Closes #2615.

Readiness checklist

  • I added/updated unit tests.
  • I added/updated integration/compatibility tests.
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@wqhhust wqhhust requested review from a team and AlekSi as code owners May 13, 2023 08:09
@wqhhust wqhhust requested a review from rumyantseva May 13, 2023 08:09
@w84thesun w84thesun changed the title 2615 envtoo shell read Add cat command to envtool May 13, 2023
@w84thesun w84thesun added the code/chore Code maintenance improvements label May 13, 2023
@w84thesun w84thesun added this to the Next milestone May 13, 2023
@codecov
Copy link

codecov bot commented May 13, 2023 •
edited
Loading

Codecov Report

Merging #2626 (3ed2ee7) into main (b863106) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2626   +/-   ##
=======================================
  Coverage   28.24%   28.24%           
=======================================
  Files         421      421           
  Lines       20846    20846           
=======================================
  Hits         5887     5887           
  Misses      14361    14361           
  Partials      598      598
Flag Coverage Δ
integration 5.32% <ø> (ø)
mongodb 5.32% <ø> (ø)
unit 26.72% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

AlekSi
AlekSi reviewed May 13, 2023
View reviewed changes
Copy link
Member

@AlekSi AlekSi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's rename cat to read everywhere

cmd/envtool/envtool.go Outdated Show resolved Hide resolved
cmd/envtool/envtool.go Outdated Show resolved Hide resolved
@wqhhust
Copy link
Contributor Author

wqhhust commented May 13, 2023

done

image

@AlekSi
Copy link
Member

AlekSi commented May 15, 2023

Please run task fmt-yaml, the re-request review (see the last point here).

@wqhhust wqhhust requested a review from AlekSi May 15, 2023 10:24
rumyantseva
rumyantseva suggested changes May 16, 2023
View reviewed changes
Copy link
Contributor

@rumyantseva rumyantseva left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the current approach task pacakges doesn't work anymore. I tried it on Mac, and it failed. But when I run task packages from the main branch, it works. So, it needs to be fixed.

The version should be calculated before docker buildx is called, so an approach with calling a command (sh:) needs to be kept.

Screenshot 2023-05-16 at 13 10 01

rumyantseva
rumyantseva reviewed May 16, 2023
View reviewed changes
Taskfile.yml Outdated Show resolved Hide resolved
@wqhhust
Copy link
Contributor Author

wqhhust commented May 16, 2023

Added back the sh. thx for your review

@wqhhust wqhhust requested a review from rumyantseva May 16, 2023 12:52
@rumyantseva rumyantseva changed the title Add cat command to envtool Implement envtool shell read subcommand May 16, 2023
@rumyantseva rumyantseva enabled auto-merge (squash) May 16, 2023 13:55
@rumyantseva rumyantseva disabled auto-merge May 16, 2023 13:55
@rumyantseva rumyantseva enabled auto-merge (squash) May 16, 2023 13:55
rumyantseva
rumyantseva approved these changes May 16, 2023
View reviewed changes
Copy link
Contributor

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing! The proposed approach looks good to me.

I renamed the PR title, so it matches the issue title - we describe the command we implement.

@rumyantseva rumyantseva changed the title Implement envtool shell read subcommand Implement envtool shell read subcommand May 16, 2023
w84thesun
w84thesun approved these changes May 16, 2023
View reviewed changes
Copy link
Contributor

@w84thesun w84thesun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rumyantseva rumyantseva merged commit 5b96bd8 into FerretDB:main May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rumyantseva rumyantseva rumyantseva approved these changes

@w84thesun w84thesun w84thesun approved these changes

@AlekSi AlekSi AlekSi approved these changes

Assignees

@wqhhust wqhhust

Labels
code/chore Code maintenance improvements
Projects
Current Engineering
Archived in project
Milestone
v1.2.0
Development

Successfully merging this pull request may close these issues.

Implement envtool shell read subcommand
4 participants
@wqhhust @AlekSi @w84thesun @rumyantseva