Simplify envtool shell subcommands
#2614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlekSi
commented
May 11, 2023
|
@kropidlowsky PTAL |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2614 +/- ##
===========================================
+ Coverage 27.77% 58.80% +31.03%
===========================================
Files 419 417 -2
Lines 20549 20313 -236
===========================================
+ Hits 5707 11946 +6239
+ Misses 14256 7480 -6776
- Partials 586 887 +301 see 208 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
@AlekSi Thanks a lot! |
AlekSi
requested review from
w84thesun,
rumyantseva,
a team,
chilagrow and
noisersup
and removed request for
w84thesun and
rumyantseva
AlekSi
requested review from
a team,
w84thesun and
rumyantseva
and removed request for
a team
w84thesun
approved these changes
May 11, 2023
rumyantseva
approved these changes
May 11, 2023
There was a problem hiding this comment.
Great! I tried various tasks on Windows, they work apart from packages.
I think the last thing we need to decide about is how to retrieve the version for packages-deb/packages-rpm because sh: cat doesn't work as is. Though, powershell itself supports cat command (as an alias).
chilagrow
approved these changes
May 12, 2023
chilagrow
approved these changes
May 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Readiness checklist
task all, and it passed.@FerretDB/core), Labels, Project and project's Sprint fields.