Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix compatibility with C# driver #2613

Merged
merged 4 commits into from
May 11, 2023
Merged

Fix compatibility with C# driver #2613

merged 4 commits into from
May 11, 2023

Conversation

b1ron
Copy link
Contributor

@b1ron b1ron commented May 11, 2023 •
edited by AlekSi
Loading

Description

Closes #2516.

This allows the C# driver to complete a server handshake and prevents it from sending a getLastError command.

Readiness checklist

  • I added/updated unit tests.
  • I added/updated integration/compatibility tests.
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@b1ron b1ron self-assigned this May 11, 2023
@b1ron b1ron added the code/bug Some user-visible feature works incorrectly label May 11, 2023
@b1ron b1ron changed the title Send a connection ID in isMaster response Send a connection ID in isMaster response for OP_QUERY May 11, 2023
@b1ron b1ron marked this pull request as ready for review May 11, 2023 16:38
@b1ron b1ron requested a review from a team as a code owner May 11, 2023 16:38
@b1ron b1ron requested review from AlekSi and rumyantseva May 11, 2023 16:38
@b1ron b1ron enabled auto-merge (squash) May 11, 2023 16:38
@b1ron b1ron requested review from a team, w84thesun, chilagrow and noisersup May 11, 2023 16:38
@codecov
Copy link

codecov bot commented May 11, 2023 •
edited
Loading

Codecov Report

Merging #2613 (68dfab6) into main (3bcad09) will increase coverage by 22.34%.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##            main    #2613       +/-   ##
==========================================
+ Coverage   5.40%   27.74%   +22.34%     
==========================================
  Files        417      419        +2     
  Lines      20313    20549      +236     
==========================================
+ Hits        1097     5702     +4605     
+ Misses     19139    14260     -4879     
- Partials      77      587      +510
Impacted Files Coverage Δ
internal/handlers/pg/cmd_query.go 0.00% <0.00%> (ø)

... and 137 files with indirect coverage changes

Flag Coverage Δ
integration 5.40% <0.00%> (ø)
mongodb 5.40% <0.00%> (ø)
unit 26.18% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

@AlekSi AlekSi changed the title Send a connection ID in isMaster response for OP_QUERY Fix compatibility with C# driver May 11, 2023
@AlekSi AlekSi disabled auto-merge May 11, 2023 16:53
@AlekSi AlekSi enabled auto-merge (squash) May 11, 2023 16:53
@AlekSi AlekSi added this to the Next milestone May 11, 2023
@AlekSi AlekSi merged commit 1a3a301 into FerretDB:main May 11, 2023
@b1ron b1ron deleted the opreply branch May 12, 2023 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@w84thesun w84thesun w84thesun approved these changes

@AlekSi AlekSi AlekSi approved these changes

@rumyantseva rumyantseva Awaiting requested review from rumyantseva rumyantseva is a code owner automatically assigned from FerretDB/leads

@chilagrow chilagrow Awaiting requested review from chilagrow chilagrow was automatically assigned from FerretDB/core

@noisersup noisersup Awaiting requested review from noisersup noisersup was automatically assigned from FerretDB/core

Assignees

@b1ron b1ron

Labels
code/bug Some user-visible feature works incorrectly
Projects
Current Engineering
Archived in project
Milestone
v1.2.0
Development

Successfully merging this pull request may close these issues.

Can't connect by C# MongoDB Driver
3 participants
@b1ron @AlekSi @w84thesun