Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make protocol-level crashes easier to understand #2610

Merged
merged 3 commits into from
May 11, 2023

Conversation

AlekSi
Copy link
Member

@AlekSi AlekSi commented May 11, 2023

Description

Now that particular case produces "no response to send to client".

Closes #2516.

Readiness checklist

  • I added/updated integration/compatibility tests – not possible with our Go driver, tested manually.
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

Now that particular case produces "no response to send to client".

Closes FerretDB#2516.
@AlekSi AlekSi added the code/chore Code maintenance improvements label May 11, 2023
@AlekSi AlekSi added this to the Next milestone May 11, 2023
@AlekSi AlekSi self-assigned this May 11, 2023
@AlekSi AlekSi requested a review from a team as a code owner May 11, 2023 15:11
@AlekSi AlekSi requested review from w84thesun and chilagrow May 11, 2023 15:11
@AlekSi AlekSi enabled auto-merge (squash) May 11, 2023 15:12
@AlekSi AlekSi requested review from b1ron and removed request for chilagrow May 11, 2023 15:12
@codecov
Copy link

codecov bot commented May 11, 2023

Codecov Report

Merging #2610 (f612aa3) into main (d254760) will decrease coverage by 0.08%.
The diff coverage is 12.50%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2610      +/-   ##
==========================================
- Coverage   65.93%   65.86%   -0.08%     
==========================================
  Files         419      419              
  Lines       20539    20549      +10     
==========================================
- Hits        13543    13534       -9     
- Misses       6042     6062      +20     
+ Partials      954      953       -1     
Impacted Files Coverage Δ
internal/clientconn/conn.go 52.50% <12.50%> (-1.43%) ⬇️

... and 3 files with indirect coverage changes

Flag Coverage Δ
integration 58.80% <12.50%> (-0.03%) ⬇️
mongodb 5.40% <0.00%> (-0.01%) ⬇️
pg 58.71% <12.50%> (-0.03%) ⬇️
unit 26.03% <0.00%> (-0.19%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

b1ron
b1ron previously approved these changes May 11, 2023
Copy link
Contributor

@b1ron b1ron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@b1ron
Copy link
Contributor

b1ron commented May 11, 2023

You have some linter failures.

@AlekSi AlekSi requested a review from b1ron May 11, 2023 16:56
@AlekSi AlekSi requested review from a team, rumyantseva, chilagrow and noisersup May 11, 2023 16:56
@AlekSi AlekSi merged commit 3bcad09 into FerretDB:main May 11, 2023
@AlekSi AlekSi deleted the improve-crash-message branch May 11, 2023 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code/chore Code maintenance improvements
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Can't connect by C# MongoDB Driver
3 participants