Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup insert command #2609

Merged
merged 9 commits into from
May 12, 2023
Merged

Cleanup insert command #2609

merged 9 commits into from
May 12, 2023

Conversation

noisersup
Copy link
Member

@noisersup noisersup commented May 11, 2023 •
edited
Loading

Description

Closes #2510.

Readiness checklist

  • I added/updated unit tests.
  • I added/updated integration/compatibility tests.
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@mergify
Copy link
Contributor

mergify bot commented May 11, 2023

@noisersup this pull request has merge conflicts.

@mergify mergify bot added the conflict PRs that have merge conflicts label May 11, 2023
@mergify mergify bot removed the conflict PRs that have merge conflicts label May 11, 2023
@noisersup noisersup added the code/enhancement Some user-visible feature could work better label May 11, 2023
@codecov
Copy link

codecov bot commented May 11, 2023 •
edited
Loading

Codecov Report

Merging #2609 (e83298a) into main (9249bc4) will decrease coverage by 38.13%.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #2609       +/-   ##
===========================================
- Coverage   65.90%   27.77%   -38.13%     
===========================================
  Files         419      419               
  Lines       20549    20545        -4     
===========================================
- Hits        13543     5707     -7836     
- Misses       6052    14252     +8200     
+ Partials      954      586      -368
Impacted Files Coverage Δ
internal/handlers/pg/msg_findandmodify.go 0.00% <0.00%> (-78.19%) ⬇️
internal/handlers/pg/msg_insert.go 0.00% <0.00%> (-80.18%) ⬇️
internal/handlers/pg/msg_update.go 0.00% <0.00%> (-63.81%) ⬇️

... and 135 files with indirect coverage changes

Flag Coverage Δ
integration 5.40% <0.00%> (-53.41%) ⬇️
mongodb 5.40% <0.00%> (+<0.01%) ⬆️
pg ?
unit 26.21% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@noisersup noisersup changed the title insertMany cleanup Cleanup insert command May 11, 2023
@noisersup noisersup marked this pull request as ready for review May 11, 2023 16:43
@noisersup noisersup requested a review from a team as a code owner May 11, 2023 16:43
@noisersup noisersup requested review from w84thesun, chilagrow, a team and rumyantseva May 11, 2023 16:43
@w84thesun w84thesun enabled auto-merge (squash) May 11, 2023 19:20
w84thesun
w84thesun approved these changes May 11, 2023
View reviewed changes
Copy link
Contributor

@w84thesun w84thesun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@noisersup noisersup requested review from a team May 12, 2023 07:57
@w84thesun w84thesun merged commit 16c6a18 into FerretDB:main May 12, 2023
@AlekSi AlekSi added this to the v1.2.0 milestone May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chilagrow chilagrow chilagrow approved these changes

@w84thesun w84thesun w84thesun approved these changes

@rumyantseva rumyantseva Awaiting requested review from rumyantseva rumyantseva was automatically assigned from FerretDB/core

Assignees

@noisersup noisersup

Labels
code/enhancement Some user-visible feature could work better
Projects
Current Engineering
Archived in project
Milestone
v1.2.0
Development

Successfully merging this pull request may close these issues.

Perform insertMany in a single transaction
4 participants
@noisersup @w84thesun @chilagrow @AlekSi