Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add sqlite handler stub #2608

Merged
merged 5 commits into from
May 11, 2023
Merged

Add sqlite handler stub #2608

merged 5 commits into from
May 11, 2023

Conversation

AlekSi
Copy link
Member

@AlekSi AlekSi commented May 11, 2023

Description

Closes #1095.

Readiness checklist

  • I added/updated unit tests.
  • I added/updated integration/compatibility tests.
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@AlekSi AlekSi added code/chore Code maintenance improvements backend/sqlite Issues about SQLite backend labels May 11, 2023
@AlekSi AlekSi added this to the Next milestone May 11, 2023
@AlekSi AlekSi self-assigned this May 11, 2023
@AlekSi AlekSi marked this pull request as ready for review May 11, 2023 11:58
@AlekSi AlekSi requested review from ptrfarkas and a team as code owners May 11, 2023 11:58
@AlekSi AlekSi requested review from w84thesun and rumyantseva May 11, 2023 11:58
@AlekSi AlekSi enabled auto-merge (squash) May 11, 2023 11:58
@AlekSi AlekSi requested review from a team, chilagrow and noisersup May 11, 2023 11:59
@codecov
Copy link

codecov bot commented May 11, 2023 •
edited
Loading

Codecov Report

Merging #2608 (9de09e3) into main (2271634) will increase coverage by 0.00%.
The diff coverage is 70.83%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2608   +/-   ##
=======================================
  Coverage   27.78%   27.78%           
=======================================
  Files         417      419    +2     
  Lines       20533    20539    +6     
=======================================
+ Hits         5705     5707    +2     
- Misses      14242    14246    +4     
  Partials      586      586
Impacted Files Coverage Δ
internal/handlers/registry/hana.go 7.69% <0.00%> (-0.65%) ⬇️
internal/handlers/registry/registry.go 53.84% <ø> (-17.13%) ⬇️
internal/handlers/registry/tigris.go 4.76% <0.00%> (-0.24%) ⬇️
internal/handlers/sqlite/cmd_query.go 0.00% <ø> (ø)
internal/handlers/sqlite/msg_aggregate.go 0.00% <ø> (ø)
internal/handlers/sqlite/msg_buildinfo.go 0.00% <ø> (ø)
internal/handlers/sqlite/msg_collmod.go 0.00% <ø> (ø)
internal/handlers/sqlite/msg_collstats.go 0.00% <ø> (ø)
internal/handlers/sqlite/msg_connectionstatus.go 0.00% <ø> (ø)
internal/handlers/sqlite/msg_count.go 0.00% <ø> (ø)
... and 38 more

... and 3 files with indirect coverage changes

Flag Coverage Δ
integration 5.40% <8.33%> (+<0.01%) ⬆️
mongodb 5.40% <8.33%> (+<0.01%) ⬆️
unit 26.22% <70.83%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

rumyantseva
rumyantseva previously approved these changes May 11, 2023
View reviewed changes
Copy link
Contributor

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

w84thesun
w84thesun previously approved these changes May 11, 2023
View reviewed changes
Copy link
Contributor

@w84thesun w84thesun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@AlekSi AlekSi added the not ready Issues that are not ready to be worked on; PRs that should skip CI label May 11, 2023
@AlekSi AlekSi dismissed stale reviews from rumyantseva and w84thesun via 9de09e3 May 11, 2023 15:46
@AlekSi AlekSi removed the not ready Issues that are not ready to be worked on; PRs that should skip CI label May 11, 2023
@AlekSi AlekSi disabled auto-merge May 11, 2023 15:58
@AlekSi AlekSi merged commit d254760 into FerretDB:main May 11, 2023
@AlekSi AlekSi deleted the sqlite-stub branch May 11, 2023 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rumyantseva rumyantseva rumyantseva left review comments

@w84thesun w84thesun w84thesun left review comments

@ptrfarkas ptrfarkas Awaiting requested review from ptrfarkas ptrfarkas is a code owner

@chilagrow chilagrow Awaiting requested review from chilagrow chilagrow was automatically assigned from FerretDB/core

@noisersup noisersup Awaiting requested review from noisersup noisersup was automatically assigned from FerretDB/core

Assignees

@AlekSi AlekSi

Labels
backend/sqlite Issues about SQLite backend code/chore Code maintenance improvements
Projects
Current Engineering
Archived in project
Milestone
v1.2.0
Development

Successfully merging this pull request may close these issues.

Design and prototype common storage interface
3 participants
@AlekSi @w84thesun @rumyantseva