Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add documentation for .rpm packages #2604

Merged
merged 3 commits into from
May 11, 2023
Merged

Add documentation for .rpm packages #2604

merged 3 commits into from
May 11, 2023

Conversation

AlekSi
Copy link
Member

@AlekSi AlekSi commented May 11, 2023

Description

Improve documentation for .deb packages.
Tweak how packages are built.

Readiness checklist

  • I added/updated unit tests.
  • I added/updated integration/compatibility tests.
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@AlekSi AlekSi added documentation Something user-visible is badly or not documented trust PRs that can access Actions secrets labels May 11, 2023
@AlekSi AlekSi added this to the Next milestone May 11, 2023
@AlekSi AlekSi requested a review from ptrfarkas as a code owner May 11, 2023 06:20
@AlekSi AlekSi self-assigned this May 11, 2023
@AlekSi AlekSi enabled auto-merge (squash) May 11, 2023 06:20
@AlekSi AlekSi added the do not merge PRs that should not be merged label May 11, 2023
@AlekSi
Copy link
Member Author

AlekSi commented May 11, 2023

@Fashander PTAL

@AlekSi AlekSi added packages PRs that should build packages and removed do not merge PRs that should not be merged labels May 11, 2023
@codecov
Copy link

codecov bot commented May 11, 2023 •
edited
Loading

Codecov Report

Merging #2604 (f39bfdd) into main (6262587) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2604   +/-   ##
=======================================
  Coverage   27.27%   27.27%           
=======================================
  Files         414      414           
  Lines       20383    20383           
=======================================
  Hits         5559     5559           
  Misses      14248    14248           
  Partials      576      576
Flag Coverage Δ
integration 5.44% <ø> (ø)
mongodb 5.44% <ø> (ø)
unit 25.64% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

chilagrow
chilagrow approved these changes May 11, 2023
View reviewed changes
Copy link
Member

@chilagrow chilagrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

rumyantseva
rumyantseva approved these changes May 11, 2023
View reviewed changes
Copy link
Contributor

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlekSi AlekSi merged commit e62ea7f into FerretDB:main May 11, 2023
@AlekSi AlekSi deleted the rpm-docs branch May 11, 2023 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fashander Fashander Fashander approved these changes

@chilagrow chilagrow chilagrow approved these changes

@rumyantseva rumyantseva rumyantseva approved these changes

@ptrfarkas ptrfarkas Awaiting requested review from ptrfarkas ptrfarkas is a code owner

@w84thesun w84thesun Awaiting requested review from w84thesun w84thesun was automatically assigned from FerretDB/core

@noisersup noisersup Awaiting requested review from noisersup noisersup was automatically assigned from FerretDB/core

Assignees

@AlekSi AlekSi

Labels
documentation Something user-visible is badly or not documented packages PRs that should build packages trust PRs that can access Actions secrets
Projects
Current Engineering
Archived in project
Milestone
v1.2.0
Development

Successfully merging this pull request may close these issues.
4 participants
@AlekSi @rumyantseva @chilagrow @Fashander