Add experimental integration test flag for pushdown sorting #2595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noisersup
requested review from
AlekSi,
w84thesun,
a team,
rumyantseva and
chilagrow
AlekSi
reviewed
May 9, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2595 +/- ##
===========================================
- Coverage 65.70% 27.20% -38.50%
===========================================
Files 414 414
Lines 20365 20366 +1
===========================================
- Hits 13380 5540 -7840
- Misses 6032 14248 +8216
+ Partials 953 578 -375
... and 134 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more. |
AlekSi
approved these changes
May 9, 2023
AlekSi
previously approved these changes
May 9, 2023
chilagrow
reviewed
May 10, 2023
AlekSi
reviewed
May 10, 2023
chilagrow
approved these changes
May 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Tested locally with and without the flag,
ORDER BYis appended as expected.Added 2 test cases that satisfy pushdown requirements.
Closes #2438.
Readiness checklist
task all, and it passed.@FerretDB/core), Labels, Project and project's Sprint fields.