Do panic in integration tests if connection can't be established #2577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2577 +/- ##
==========================================
- Coverage 27.29% 27.28% -0.01%
==========================================
Files 411 411
Lines 20148 20148
==========================================
- Hits 5500 5498 -2
- Misses 14077 14078 +1
- Partials 571 572 +1
Flags with carried forward coverage won't be shown. Click here to find out more. |
rumyantseva
changed the title
AlekSi
reviewed
May 8, 2023
rumyantseva
changed the title
AlekSi
approved these changes
May 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In
integration/setup/listener.goin thetb.Cleanupcall we wait for a message fromdonechannel. If the connection with the client wasn't established, this message will be never received, as listener is still runing. As a result, the tests are hanging until timeout. This PR fixes this problem by panicking if the connection can't be established.For example, this problem occurred in this #2540 PR, and it was hard to catch the problem with failing integration tests.
Readiness checklist
task all, and it passed.@FerretDB/core), Labels, Project and project's Sprint fields.