Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small refactoring #2575

Merged
merged 3 commits into from
May 8, 2023
Merged

Small refactoring #2575

merged 3 commits into from
May 8, 2023

Conversation

AlekSi
Copy link
Member

@AlekSi AlekSi commented May 8, 2023

Description

Move code around.

Readiness checklist

  • I added/updated unit tests.
  • I added/updated integration/compatibility tests.
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@AlekSi
Small refactoring
9ab9ce7 
Move code around.
@AlekSi AlekSi added the code/chore Code maintenance improvements label May 8, 2023
@AlekSi AlekSi added this to the v1.1.0 milestone May 8, 2023
@AlekSi AlekSi self-assigned this May 8, 2023
@codecov
Copy link

codecov bot commented May 8, 2023 •
edited
Loading

Codecov Report

Merging #2575 (fbddd6e) into main (050702e) will decrease coverage by 0.03%.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2575      +/-   ##
==========================================
- Coverage   27.28%   27.26%   -0.03%     
==========================================
  Files         411      410       -1     
  Lines       20148    20149       +1     
==========================================
- Hits         5498     5493       -5     
- Misses      14078    14083       +5     
- Partials      572      573       +1
Impacted Files Coverage Δ
...rnal/handlers/common/aggregations/operators/sum.go 0.00% <0.00%> (ø)
internal/handlers/common/aggregations/pushdown.go 0.00% <ø> (ø)
...l/handlers/common/aggregations/stages/collstats.go 0.00% <0.00%> (ø)
...ernal/handlers/common/aggregations/stages/count.go 0.00% <0.00%> (ø)
...ernal/handlers/common/aggregations/stages/group.go 0.00% <0.00%> (ø)
...ernal/handlers/common/aggregations/stages/limit.go 0.00% <0.00%> (ø)
...ernal/handlers/common/aggregations/stages/match.go 0.00% <0.00%> (ø)
...nal/handlers/common/aggregations/stages/project.go 0.00% <0.00%> (ø)
...ternal/handlers/common/aggregations/stages/skip.go 0.00% <0.00%> (ø)
...ternal/handlers/common/aggregations/stages/sort.go 0.00% <0.00%> (ø)
... and 7 more

... and 2 files with indirect coverage changes

Flag Coverage Δ
integration 5.50% <0.00%> (-0.01%) ⬇️
mongodb 5.50% <0.00%> (-0.01%) ⬇️
unit 25.61% <0.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@AlekSi AlekSi marked this pull request as ready for review May 8, 2023 15:08
@AlekSi AlekSi requested a review from a team as a code owner May 8, 2023 15:08
@AlekSi AlekSi requested review from w84thesun and chilagrow May 8, 2023 15:08
@AlekSi AlekSi enabled auto-merge (squash) May 8, 2023 15:08
@AlekSi AlekSi requested review from a team, rumyantseva and noisersup May 8, 2023 15:08
w84thesun
w84thesun approved these changes May 8, 2023
View reviewed changes
Copy link
Contributor

@w84thesun w84thesun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlekSi AlekSi merged commit 021a4b6 into FerretDB:main May 8, 2023
@AlekSi AlekSi deleted the small-refactoring branch May 8, 2023 18:58
@AlekSi AlekSi modified the milestones: v1.1.0, v1.2.0 May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noisersup noisersup noisersup approved these changes

@w84thesun w84thesun w84thesun approved these changes

@chilagrow chilagrow Awaiting requested review from chilagrow chilagrow is a code owner automatically assigned from FerretDB/leads

@rumyantseva rumyantseva Awaiting requested review from rumyantseva rumyantseva was automatically assigned from FerretDB/core

Assignees

@AlekSi AlekSi

Labels
code/chore Code maintenance improvements
Projects
Current Engineering
Archived in project
Milestone
v1.2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@AlekSi @w84thesun @noisersup