Fix runCommand's inserts of documents without _ids
#2574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2574 +/- ##
==========================================
- Coverage 65.61% 65.59% -0.02%
==========================================
Files 411 411
Lines 20134 20148 +14
==========================================
+ Hits 13210 13217 +7
- Misses 5982 5989 +7
Partials 942 942
... and 1 file with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more. |
That problem usually occurs when we modify the original message and then try to send it to a proxy. As a result of this I made the necessary changes to make it work. |
w84thesun
changed the title
runCommand's inserts of documents without _ids runCommand's inserts of documents without _ids
rumyantseva
reviewed
May 8, 2023
rumyantseva
reviewed
May 8, 2023
rumyantseva
reviewed
May 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #1714 .
_ids generation forrunCommandinsert.IT DOES NOT WORK FULLY!
While running
db.runCommand({ insert: "{collection}", documents: [ {v: "abc" } ]})it fails:clientconn/conn.go:164 expected length 95 (marshaled body size) + 16 (fixed marshaled header size) = 111, got 94.However, when the FerretDB is run once again the inserted value appears in the collection.
Thank you in advance for help!
Readiness checklist
task all, and it passed.@FerretDB/core), Labels, Project and project's Sprint fields.