Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove TODO comment for closed issue #2573

Merged
merged 10 commits into from
May 10, 2023
Merged

Remove TODO comment for closed issue #2573

merged 10 commits into from
May 10, 2023

Conversation

adetunjii
Copy link
Contributor

Description

This fix removes TODO for closed out issues.

Readiness checklist

  • I added/updated unit tests.
  • I added/updated integration/compatibility tests.
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@adetunjii adetunjii requested a review from a team as a code owner May 6, 2023 10:56
@adetunjii adetunjii requested review from AlekSi and chilagrow May 6, 2023 10:56
@CLAassistant
Copy link

CLAassistant commented May 6, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

chilagrow
chilagrow previously approved these changes May 8, 2023
View reviewed changes
Copy link
Member

@chilagrow chilagrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the clean up 🤗

AlekSi
AlekSi reviewed May 8, 2023
View reviewed changes
internal/wire/msg_body.go Outdated Show resolved Hide resolved
@AlekSi
Copy link
Member

AlekSi commented May 8, 2023

@adetunjii please click a button in this comments: #2573 (comment)

@AlekSi AlekSi added the code/chore Code maintenance improvements label May 8, 2023
@codecov
Copy link

codecov bot commented May 8, 2023 •
edited
Loading

Codecov Report

Merging #2573 (05d82b9) into main (ccaf200) will decrease coverage by 0.05%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2573      +/-   ##
==========================================
- Coverage   65.73%   65.69%   -0.05%     
==========================================
  Files         414      414              
  Lines       20344    20344              
==========================================
- Hits        13374    13365       -9     
- Misses       6021     6027       +6     
- Partials      949      952       +3

see 1 file with indirect coverage changes

Flag Coverage Δ
integration 58.80% <ø> (-0.05%) ⬇️
mongodb 5.45% <ø> (ø)
pg 58.70% <ø> (-0.05%) ⬇️
unit 25.59% <ø> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@AlekSi AlekSi enabled auto-merge (squash) May 9, 2023 14:26
@AlekSi AlekSi changed the title Remove TODO tag for closed issue Remove TODO comment for closed issue May 9, 2023
@AlekSi AlekSi added this to the Next milestone May 9, 2023
@AlekSi AlekSi requested a review from chilagrow May 9, 2023 14:27
@AlekSi AlekSi merged commit 0485ea3 into FerretDB:main May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chilagrow chilagrow chilagrow approved these changes

@AlekSi AlekSi AlekSi approved these changes

Assignees

@adetunjii adetunjii

Labels
code/chore Code maintenance improvements
Projects
Current Engineering
Archived in project
Milestone
v1.2.0
Development

Successfully merging this pull request may close these issues.
4 participants
@adetunjii @CLAassistant @AlekSi @chilagrow