Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add proper CLI to envtool - envtool setup subcommand #2570

Merged
merged 1 commit into from
May 4, 2023
Merged

Add proper CLI to envtool - envtool setup subcommand #2570

merged 1 commit into from
May 4, 2023

Conversation

kropidlowsky
Copy link
Contributor

Description

Closes #2550 .

Added envtool setup kong subcommand.

Readiness checklist

  • I added/updated unit tests.
  • I added/updated integration/compatibility tests.
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@kropidlowsky kropidlowsky requested review from a team and AlekSi as code owners May 4, 2023 19:48
@kropidlowsky kropidlowsky requested a review from w84thesun May 4, 2023 19:48
@AlekSi AlekSi enabled auto-merge (squash) May 4, 2023 19:53
@AlekSi AlekSi added this to the v1.1.0 milestone May 4, 2023
@AlekSi AlekSi added the code/chore Code maintenance improvements label May 4, 2023
@codecov
Copy link

codecov bot commented May 4, 2023 •
edited
Loading

Codecov Report

Merging #2570 (9fd2395) into main (71b70aa) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2570   +/-   ##
=======================================
  Coverage   65.15%   65.15%           
=======================================
  Files         410      410           
  Lines       20071    20071           
=======================================
  Hits        13077    13077           
  Misses       6055     6055           
  Partials      939      939

see 1 file with indirect coverage changes

Flag Coverage Δ
integration 57.89% <ø> (ø)
mongodb 5.04% <ø> (ø)
pg 57.82% <ø> (ø)
unit 25.69% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

w84thesun
w84thesun approved these changes May 4, 2023
View reviewed changes
Copy link
Contributor

@w84thesun w84thesun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

@AlekSi AlekSi merged commit 27fc560 into FerretDB:main May 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@w84thesun w84thesun w84thesun approved these changes

@AlekSi AlekSi AlekSi approved these changes

Assignees

@kropidlowsky kropidlowsky

Labels
code/chore Code maintenance improvements
Projects
Current Engineering
Archived in project
Milestone
v1.1.0
Development

Successfully merging this pull request may close these issues.

Add proper CLI to envtool
3 participants
@kropidlowsky @AlekSi @w84thesun