Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a README.md file for assertions #2569

Merged
merged 44 commits into from
May 12, 2023
Merged

Add a README.md file for assertions #2569

merged 44 commits into from
May 12, 2023

Conversation

b1ron
Copy link
Contributor

@b1ron b1ron commented May 4, 2023

Description

Closes #2543.

Readiness checklist

  • I added/updated unit tests.
  • I added/updated integration/compatibility tests.
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@mergify mergify bot assigned b1ron May 4, 2023
@codecov
Copy link

codecov bot commented May 4, 2023

Codecov Report

Merging #2569 (ae8166e) into main (2516bb1) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2569   +/-   ##
=======================================
  Coverage   27.60%   27.60%           
=======================================
  Files         419      419           
  Lines       20703    20703           
=======================================
  Hits         5716     5716           
  Misses      14401    14401           
  Partials      586      586           
Flag Coverage Δ
integration 5.36% <ø> (ø)
mongodb 5.36% <ø> (ø)
unit 26.04% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@b1ron b1ron marked this pull request as ready for review May 8, 2023 13:30
@b1ron b1ron requested a review from a team as a code owner May 8, 2023 13:30
@b1ron
Copy link
Contributor Author

b1ron commented May 8, 2023

Still have some linter issues and I cannot seem to install golangci-lint and docs using go generate -x.

Copy link
Member

@AlekSi AlekSi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@AlekSi AlekSi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also run task docs-fmt locally

@AlekSi
Copy link
Member

AlekSi commented May 8, 2023

Still have some linter issues and I cannot seem to install golangci-lint and docs using go generate -x.

Not sure how you want to use golangci-lint for Markdown 😋 But please run task env-reset

Copy link
Member

@chilagrow chilagrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

chilagrow
chilagrow previously approved these changes May 11, 2023
Copy link
Member

@chilagrow chilagrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@b1ron
Copy link
Contributor Author

b1ron commented May 11, 2023

I added more, sorry need another review. Plus I had to update branch.

Copy link
Member

@noisersup noisersup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

build/legacy-mongo-shell/README.md Outdated Show resolved Hide resolved
@AlekSi AlekSi disabled auto-merge May 12, 2023 12:41
@AlekSi AlekSi added this to the Next milestone May 12, 2023
@AlekSi AlekSi enabled auto-merge (squash) May 12, 2023 12:42
@AlekSi AlekSi merged commit 9a52d87 into FerretDB:main May 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code/chore Code maintenance improvements
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Document what legacy-mongo-shell test script helpers are available
6 participants