-
Notifications
You must be signed in to change notification settings - Fork 409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a README.md file for assertions #2569
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2569 +/- ##
=======================================
Coverage 27.60% 27.60%
=======================================
Files 419 419
Lines 20703 20703
=======================================
Hits 5716 5716
Misses 14401 14401
Partials 586 586
Flags with carried forward coverage won't be shown. Click here to find out more. |
Still have some linter issues and I cannot seem to install |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should also update https://github.com/FerretDB/FerretDB/blob/main/CONTRIBUTING.md#reporting-a-bug
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also run task docs-fmt
locally
Not sure how you want to use golangci-lint for Markdown 😋 But please run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
I added more, sorry need another review. Plus I had to update branch. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Description
Closes #2543.
Readiness checklist
task all
, and it passed.@FerretDB/core
), Labels, Project and project's Sprint fields.