Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Recover from more errors, close connection less often #2564

Merged
merged 15 commits into from
May 5, 2023
Merged

Recover from more errors, close connection less often #2564

merged 15 commits into from
May 5, 2023

Conversation

AlekSi
Copy link
Member

@AlekSi AlekSi commented May 3, 2023 •
edited
Loading

Description

Closes #2394.
Refs #2545.
Refs #2412.

Readiness checklist

  • I added/updated unit tests.
  • I added/updated integration/compatibility tests.
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@AlekSi AlekSi added code/chore Code maintenance improvements no ci labels May 3, 2023
@AlekSi AlekSi added this to the v1.1.0 milestone May 3, 2023
@AlekSi AlekSi self-assigned this May 3, 2023
@AlekSi AlekSi mentioned this pull request May 4, 2023
Closed
@AlekSi AlekSi mentioned this pull request May 4, 2023
Closed
9 tasks
@AlekSi AlekSi mentioned this pull request May 4, 2023
Closed
9 tasks
@AlekSi AlekSi changed the title Tweak error checking a bit Recover from more errors, close connection less often May 4, 2023
@AlekSi AlekSi removed the no ci label May 4, 2023
@codecov
Copy link

codecov bot commented May 4, 2023 •
edited
Loading

Codecov Report

Merging #2564 (df6636b) into main (4bf7563) will increase coverage by 0.25%.
The diff coverage is 74.38%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2564      +/-   ##
==========================================
+ Coverage   65.15%   65.40%   +0.25%     
==========================================
  Files         410      410              
  Lines       20071    20104      +33     
==========================================
+ Hits        13077    13150      +73     
+ Misses       6055     6012      -43     
- Partials      939      942       +3
Impacted Files Coverage Δ
internal/handlers/proxy/proxy.go 0.00% <0.00%> (ø)
internal/handlers/common/msg_debugerror.go 25.00% <50.00%> (+25.00%) ⬆️
internal/handlers/commonerrors/write.go 70.27% <52.94%> (-2.20%) ⬇️
integration/helpers.go 74.24% <56.75%> (+2.37%) ⬆️
internal/clientconn/conn.go 53.80% <93.93%> (+8.32%) ⬆️
integration/setup/test_helpers.go 91.42% <100.00%> (+2.53%) ⬆️
internal/handlers/common/parse_osrelease.go 81.25% <100.00%> (+3.97%) ⬆️
internal/handlers/commonerrors/error.go 70.00% <100.00%> (+21.61%) ⬆️
internal/handlers/pg/pgdb/database_metadata.go 82.50% <100.00%> (ø)
internal/wire/op_msg.go 57.96% <100.00%> (+0.37%) ⬆️
... and 1 more

... and 2 files with indirect coverage changes

Flag Coverage Δ
integration 58.32% <73.55%> (+0.43%) ⬆️
mongodb 5.09% <10.74%> (+0.05%) ⬆️
pg 58.22% <69.42%> (+0.40%) ⬆️
unit 25.63% <13.15%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@AlekSi AlekSi marked this pull request as ready for review May 5, 2023 05:07
@AlekSi AlekSi requested a review from a team as a code owner May 5, 2023 05:07
@AlekSi AlekSi requested review from rumyantseva and chilagrow May 5, 2023 05:07
@AlekSi AlekSi enabled auto-merge (squash) May 5, 2023 05:07
@AlekSi AlekSi requested review from a team and w84thesun May 5, 2023 05:07
@AlekSi AlekSi requested a review from noisersup May 5, 2023 05:07
rumyantseva
rumyantseva approved these changes May 5, 2023
View reviewed changes
Copy link
Contributor

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The refactoring makes sense, a couple of TODOs are a bit confusing.

internal/wire/validation.go Show resolved Hide resolved
internal/wire/op_msg.go Show resolved Hide resolved
w84thesun
w84thesun approved these changes May 5, 2023
View reviewed changes
Copy link
Contributor

@w84thesun w84thesun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlekSi AlekSi disabled auto-merge May 5, 2023 12:59
@AlekSi AlekSi merged commit ce7ca66 into FerretDB:main May 5, 2023
@AlekSi AlekSi deleted the error-handling branch May 5, 2023 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rumyantseva rumyantseva rumyantseva approved these changes

@w84thesun w84thesun w84thesun approved these changes

@chilagrow chilagrow Awaiting requested review from chilagrow chilagrow is a code owner automatically assigned from FerretDB/leads

@noisersup noisersup Awaiting requested review from noisersup noisersup was automatically assigned from FerretDB/core

Assignees

@AlekSi AlekSi

Labels
code/chore Code maintenance improvements
Projects
Current Engineering
Archived in project
Milestone
v1.1.0
Development

Successfully merging this pull request may close these issues.

Fix handling of internal errors
3 participants
@AlekSi @w84thesun @rumyantseva