Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove version and name assertions in integration tests #2552

Merged
merged 2 commits into from
May 2, 2023
Merged

Remove version and name assertions in integration tests #2552

merged 2 commits into from
May 2, 2023

Conversation

raeidish
Copy link
Contributor

@raeidish raeidish commented May 2, 2023

Description

Closes #2500.

  • I added/updated unit tests.
  • I added/updated integration/compatibility tests.
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@raeidish raeidish requested a review from a team as a code owner May 2, 2023 13:06
@raeidish raeidish requested review from AlekSi and rumyantseva May 2, 2023 13:06
@AlekSi AlekSi added this to the v1.1.0 milestone May 2, 2023
@AlekSi AlekSi added the code/chore Code maintenance improvements label May 2, 2023
@AlekSi AlekSi requested review from a team, w84thesun, chilagrow and noisersup May 2, 2023 13:06
@AlekSi AlekSi enabled auto-merge (squash) May 2, 2023 13:07
@codecov
Copy link

codecov bot commented May 2, 2023

Codecov Report

Merging #2552 (180bbe8) into main (93e6981) will decrease coverage by 37.42%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #2552       +/-   ##
===========================================
- Coverage   64.38%   26.97%   -37.42%     
===========================================
  Files         403      403               
  Lines       20032    20032               
===========================================
- Hits        12898     5403     -7495     
- Misses       6200    14059     +7859     
+ Partials      934      570      -364     

see 129 files with indirect coverage changes

Flag Coverage Δ
integration 5.05% <ø> (-52.16%) ⬇️
mongodb 5.05% <ø> (ø)
pg ?
unit 25.59% <ø> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@AlekSi AlekSi merged commit ff10e0e into FerretDB:main May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code/chore Code maintenance improvements
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Improve how we identify Linux version in hostInfo command
3 participants