Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document not ready issues label #2544

Merged
merged 2 commits into from
May 2, 2023
Merged

Document not ready issues label #2544

merged 2 commits into from
May 2, 2023

Conversation

AlekSi
Copy link
Member

@AlekSi AlekSi commented May 2, 2023 •
edited
Loading

Description

For everyone to review.

Readiness checklist

  • I added/updated unit tests.
  • I added/updated integration/compatibility tests.
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@AlekSi AlekSi added project Project maintenance no ci do not merge PRs that should not be merged labels May 2, 2023
@AlekSi AlekSi added this to the v1.1.0 milestone May 2, 2023
@AlekSi AlekSi self-assigned this May 2, 2023
@AlekSi AlekSi marked this pull request as ready for review May 2, 2023 07:14
@AlekSi AlekSi enabled auto-merge (squash) May 2, 2023 07:14
@AlekSi AlekSi requested review from a team, w84thesun, rumyantseva, chilagrow and noisersup May 2, 2023 07:14
@AlekSi AlekSi removed the no ci label May 2, 2023
@codecov
Copy link

codecov bot commented May 2, 2023 •
edited
Loading

Codecov Report

Merging #2544 (6683d46) into main (91377b9) will increase coverage by 37.41%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #2544       +/-   ##
===========================================
+ Coverage   26.97%   64.38%   +37.41%     
===========================================
  Files         403      403               
  Lines       20032    20032               
===========================================
+ Hits         5403    12898     +7495     
+ Misses      14059     6200     -7859     
- Partials      570      934      +364

see 129 files with indirect coverage changes

Flag Coverage Δ
integration 57.20% <ø> (+52.15%) ⬆️
mongodb 5.05% <ø> (ø)
pg 57.13% <ø> (?)
unit 25.59% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

chilagrow
chilagrow approved these changes May 2, 2023
View reviewed changes
Copy link
Member

@chilagrow chilagrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🙏

rumyantseva
rumyantseva approved these changes May 2, 2023
View reviewed changes
Copy link
Contributor

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

w84thesun
w84thesun approved these changes May 2, 2023
View reviewed changes
Copy link
Contributor

@w84thesun w84thesun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@AlekSi AlekSi removed the do not merge PRs that should not be merged label May 2, 2023
@AlekSi AlekSi merged commit 93e6981 into FerretDB:main May 2, 2023
@AlekSi AlekSi deleted the issues-docs branch May 2, 2023 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fashander Fashander Fashander approved these changes

@chilagrow chilagrow chilagrow approved these changes

@rumyantseva rumyantseva rumyantseva approved these changes

@w84thesun w84thesun w84thesun approved these changes

@noisersup noisersup Awaiting requested review from noisersup noisersup was automatically assigned from FerretDB/core

Assignees

@AlekSi AlekSi

Labels
project Project maintenance
Projects
Current Engineering
Archived in project
Milestone
v1.1.0
Development

Successfully merging this pull request may close these issues.
5 participants
@AlekSi @w84thesun @rumyantseva @chilagrow @Fashander