Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add helpers for iterators and generators #2542

Merged
merged 4 commits into from
May 3, 2023
Merged

Add helpers for iterators and generators #2542

merged 4 commits into from
May 3, 2023

Conversation

AlekSi
Copy link
Member

@AlekSi AlekSi commented May 2, 2023

Description

They will be used in future PRs.

Readiness checklist

  • I added/updated unit tests.
  • I added/updated integration/compatibility tests.
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@AlekSi AlekSi added the code/chore Code maintenance improvements label May 2, 2023
@AlekSi AlekSi added this to the v1.1.0 milestone May 2, 2023
@AlekSi AlekSi requested review from a team May 2, 2023 06:52
@AlekSi AlekSi self-assigned this May 2, 2023
@AlekSi AlekSi enabled auto-merge (squash) May 2, 2023 06:52
@AlekSi AlekSi mentioned this pull request May 2, 2023
Merged
9 tasks
@codecov
Copy link

codecov bot commented May 2, 2023 •
edited
Loading

Codecov Report

Merging #2542 (50b567f) into main (ff10e0e) will decrease coverage by 0.04%.
The diff coverage is 50.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2542      +/-   ##
==========================================
- Coverage   64.38%   64.35%   -0.04%     
==========================================
  Files         403      405       +2     
  Lines       20032    20074      +42     
==========================================
+ Hits        12898    12919      +21     
- Misses       6200     6220      +20     
- Partials      934      935       +1
Impacted Files Coverage Δ
internal/util/iterator/count.go 0.00% <0.00%> (ø)
internal/util/iterator/values.go 97.36% <ø> (ø)
internal/util/iterator/with_close.go 0.00% <0.00%> (ø)
internal/util/iterator/func.go 77.77% <77.77%> (ø)
internal/util/iterator/slice.go 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

Flag Coverage Δ
integration 57.08% <6.25%> (-0.13%) ⬇️
mongodb 5.04% <0.00%> (-0.02%) ⬇️
pg 57.01% <6.25%> (-0.13%) ⬇️
unit 25.65% <50.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

chilagrow
chilagrow approved these changes May 2, 2023
View reviewed changes
Copy link
Member

@chilagrow chilagrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't yet know the usage but impl looks helpful to me 🤗

rumyantseva
rumyantseva approved these changes May 2, 2023
View reviewed changes
Copy link
Contributor

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks consistent with the previous iterator improvements.

internal/util/iterator/count.go Show resolved Hide resolved
w84thesun
w84thesun approved these changes May 2, 2023
View reviewed changes
Copy link
Contributor

@w84thesun w84thesun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@AlekSi AlekSi merged commit 30dd842 into FerretDB:main May 3, 2023
@AlekSi AlekSi deleted the iterator-helpers branch May 3, 2023 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chilagrow chilagrow chilagrow approved these changes

@rumyantseva rumyantseva rumyantseva approved these changes

@w84thesun w84thesun w84thesun approved these changes

@noisersup noisersup Awaiting requested review from noisersup noisersup was automatically assigned from FerretDB/core

Assignees

@AlekSi AlekSi

Labels
code/chore Code maintenance improvements
Projects
Current Engineering
Archived in project
Milestone
v1.1.0
Development

Successfully merging this pull request may close these issues.
4 participants
@AlekSi @w84thesun @rumyantseva @chilagrow