Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle absent os-release file #2541

Merged
merged 2 commits into from
May 2, 2023
Merged

Handle absent os-release file #2541

merged 2 commits into from
May 2, 2023

Conversation

kropidlowsky
Copy link
Contributor

@kropidlowsky kropidlowsky commented May 1, 2023 •
edited by AlekSi
Loading

Description

Closes #2500.
Based on @AlekSi 's comment:
Update identifying Linux version in hostInfo comand - based on /usr/lib/os-release instead of /usr/lib/arch-release.

Readiness checklist

  • I added/updated unit tests.
  • I added/updated integration/compatibility tests.
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@kropidlowsky kropidlowsky requested a review from a team as a code owner May 1, 2023 23:44
@kropidlowsky kropidlowsky requested review from AlekSi and w84thesun May 1, 2023 23:44
@codecov
Copy link

codecov bot commented May 1, 2023 •
edited
Loading

Codecov Report

Merging #2541 (d839913) into main (cf0328f) will decrease coverage by 0.03%.
The diff coverage is 87.50%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2541      +/-   ##
==========================================
- Coverage   64.41%   64.38%   -0.03%     
==========================================
  Files         403      403              
  Lines       20035    20032       -3     
==========================================
- Hits        12905    12898       -7     
- Misses       6198     6200       +2     
- Partials      932      934       +2
Impacted Files Coverage Δ
internal/handlers/common/msg_hostinfo.go 78.72% <80.00%> (+8.72%) ⬆️
internal/handlers/common/parse_osrelease.go 76.92% <100.00%> (ø)

... and 1 file with indirect coverage changes

Flag Coverage Δ
integration 57.20% <75.00%> (-0.03%) ⬇️
mongodb 5.05% <0.00%> (+<0.01%) ⬆️
pg 57.13% <75.00%> (-0.03%) ⬇️
unit 25.57% <37.50%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@AlekSi AlekSi added the code/enhancement Some user-visible feature could work better label May 2, 2023
@AlekSi AlekSi changed the title Update identifying Linux version in hostInfo comand Handle absent os-release file May 2, 2023
@AlekSi AlekSi added this to the v1.1.0 milestone May 2, 2023
@AlekSi AlekSi enabled auto-merge (squash) May 2, 2023 04:41
w84thesun
w84thesun approved these changes May 2, 2023
View reviewed changes
Copy link
Contributor

@w84thesun w84thesun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

@AlekSi AlekSi merged commit 91377b9 into FerretDB:main May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@w84thesun w84thesun w84thesun approved these changes

@AlekSi AlekSi AlekSi approved these changes

Assignees

@kropidlowsky kropidlowsky

Labels
code/enhancement Some user-visible feature could work better
Projects
Current Engineering
Archived in project
Milestone
v1.1.0
Development

Successfully merging this pull request may close these issues.

Improve how we identify Linux version in hostInfo command
3 participants
@kropidlowsky @AlekSi @w84thesun