Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor integration benchmarks #2537

Merged
merged 20 commits into from
May 8, 2023
Merged

Refactor integration benchmarks #2537

merged 20 commits into from
May 8, 2023

Conversation

AlekSi
Copy link
Member

@AlekSi AlekSi commented May 1, 2023 •
edited
Loading

Readiness checklist

  • I added/updated unit tests.
  • I added/updated integration/compatibility tests.
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@AlekSi AlekSi added the code/chore Code maintenance improvements label May 1, 2023
@AlekSi AlekSi added this to the v1.1.0 milestone May 1, 2023
@AlekSi AlekSi self-assigned this May 1, 2023
@codecov
Copy link

codecov bot commented May 1, 2023 •
edited
Loading

Codecov Report

Merging #2537 (2d7e03c) into main (0dd5c8c) will increase coverage by 22.22%.
The diff coverage is 66.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##            main    #2537       +/-   ##
==========================================
+ Coverage   5.09%   27.31%   +22.22%     
==========================================
  Files        408      411        +3     
  Lines      19868    20134      +266     
==========================================
+ Hits        1012     5500     +4488     
+ Misses     18781    14063     -4718     
- Partials      75      571      +496
Impacted Files Coverage Δ
integration/shareddata/shareddata.go 85.52% <ø> (+23.45%) ⬆️
internal/clientconn/conn.go 0.00% <0.00%> (ø)
integration/setup/setup.go 62.08% <25.00%> (-4.04%) ⬇️
integration/shareddata/provider.go 41.53% <41.53%> (ø)
integration/shareddata/benchmarks.go 79.45% <79.45%> (ø)
integration/shareddata/benchmark_provider.go 84.90% <84.90%> (ø)

... and 134 files with indirect coverage changes

Flag Coverage Δ
integration 5.51% <66.00%> (+0.42%) ⬆️
mongodb 5.51% <66.00%> (+0.42%) ⬆️
unit 25.65% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

@AlekSi AlekSi added the no ci label May 3, 2023
@mergify
Copy link
Contributor

mergify bot commented May 3, 2023

@AlekSi this pull request has merge conflicts.

@mergify mergify bot added the conflict PRs that have merge conflicts label May 3, 2023
@noisersup noisersup self-assigned this May 4, 2023
noisersup
noisersup reviewed May 4, 2023
View reviewed changes
Copy link
Member

@noisersup noisersup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments before working on that, nothing important

integration/shareddata/benchmark_provider.go Outdated Show resolved Hide resolved
integration/shareddata/benchmark_provider.go Show resolved Hide resolved
@mergify mergify bot removed the conflict PRs that have merge conflicts label May 5, 2023
@noisersup noisersup removed the no ci label May 5, 2023
@noisersup noisersup marked this pull request as ready for review May 5, 2023 12:23
@noisersup noisersup requested a review from a team as a code owner May 5, 2023 12:23
@noisersup noisersup requested review from w84thesun and rumyantseva May 5, 2023 12:23
@noisersup noisersup enabled auto-merge (squash) May 5, 2023 12:23
@noisersup noisersup requested review from noisersup, a team and chilagrow May 5, 2023 12:23
@AlekSi AlekSi removed their assignment May 8, 2023
AlekSi
AlekSi commented May 8, 2023
View reviewed changes
Copy link
Member Author

@AlekSi AlekSi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

w84thesun
w84thesun approved these changes May 8, 2023
View reviewed changes
Copy link
Contributor

@w84thesun w84thesun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@noisersup noisersup merged commit 2d6c82e into FerretDB:main May 8, 2023
@AlekSi AlekSi modified the milestones: v1.1.0, v1.2.0 May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chilagrow chilagrow chilagrow approved these changes

@w84thesun w84thesun w84thesun approved these changes

@rumyantseva rumyantseva Awaiting requested review from rumyantseva rumyantseva is a code owner automatically assigned from FerretDB/leads

@noisersup noisersup Awaiting requested review from noisersup

Assignees

@noisersup noisersup

Labels
code/chore Code maintenance improvements
Projects
Current Engineering
Archived in project
Milestone
v1.2.0
Development

Successfully merging this pull request may close these issues.
4 participants
@AlekSi @w84thesun @chilagrow @noisersup