Use our own Prettier Docker image #2535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It can be used without permission problems.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2535 +/- ##
===========================================
- Coverage 65.15% 27.04% -38.12%
===========================================
Files 410 410
Lines 20058 20058
===========================================
- Hits 13069 5424 -7645
- Misses 6051 14063 +8012
+ Partials 938 571 -367 see 134 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more. |
chilagrow
reviewed
May 1, 2023
There was a problem hiding this comment.
Yeah for me it has always worked without permission change on my linux. And it seems it always works for mac. But I recall without permission change it impacted @noisersup.
CI linter is unhappy though, still using task fmt 🙈
|
The old image used a custom user that is not necessary for local development tools, but introduces permission problems in some configurations |
chilagrow
approved these changes
May 1, 2023
|
@noisersup please try it out locally |
noisersup
approved these changes
May 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It can be used without permission problems.
Readiness checklist
task all, and it passed.@FerretDB/core), Labels, Project and project's Sprint fields.