Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup old Docker images #2533

Merged
merged 45 commits into from
May 12, 2023
Merged

Cleanup old Docker images #2533

merged 45 commits into from
May 12, 2023

Conversation

wqhhust
Copy link
Contributor

@wqhhust wqhhust commented Apr 29, 2023 •
edited by rumyantseva
Loading

Description

Closes #353.

Readiness checklist

  • I added/updated unit tests.
  • I added/updated integration/compatibility tests.
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@wqhhust wqhhust requested review from a team and AlekSi as code owners April 29, 2023 10:42
@wqhhust wqhhust requested a review from rumyantseva April 29, 2023 10:42
@codecov
Copy link

codecov bot commented Apr 29, 2023 •
edited
Loading

Codecov Report

Merging #2533 (d68a9eb) into main (de38f79) will decrease coverage by 38.14%.
The diff coverage is n/a.

❗ Current head d68a9eb differs from pull request most recent head a20e263. Consider uploading reports for the commit a20e263 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #2533       +/-   ##
===========================================
- Coverage   65.90%   27.77%   -38.14%     
===========================================
  Files         419      419               
  Lines       20549    20549               
===========================================
- Hits        13543     5707     -7836     
- Misses       6052    14256     +8204     
+ Partials      954      586      -368

see 138 files with indirect coverage changes

Flag Coverage Δ
integration 5.40% <ø> (-53.41%) ⬇️
mongodb 5.40% <ø> (ø)
pg ?
unit 26.20% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@wqhhust
Copy link
Contributor Author

wqhhust commented May 3, 2023

Since the lint reports the warning comes from wsl, so I run wsl manully to fix the code line by line, now it should be ok.

image

AlekSi
AlekSi requested changes May 3, 2023
View reviewed changes
cmd/cleantool/cleantool.go Outdated Show resolved Hide resolved
go.mod Outdated Show resolved Hide resolved
@wqhhust wqhhust requested a review from AlekSi May 4, 2023 00:02
@AlekSi AlekSi added this to the v1.1.0 milestone May 8, 2023
@AlekSi AlekSi added the code/chore Code maintenance improvements label May 8, 2023
@AlekSi AlekSi modified the milestones: v1.1.0, Next May 9, 2023
@mergify
Copy link
Contributor

mergify bot commented May 11, 2023

@wqhhust this pull request has merge conflicts.

@mergify mergify bot added the conflict PRs that have merge conflicts label May 11, 2023
@mergify mergify bot removed the conflict PRs that have merge conflicts label May 11, 2023
@AlekSi
Copy link
Member

AlekSi commented May 11, 2023

@wqhhust could you please

  • run git pull to merge changes in this PR to your local branch;
  • run task env-reset to reset and re-download everything;
  • run task lint and provide the full output?

@AlekSi AlekSi requested a review from chilagrow May 12, 2023 06:25
@AlekSi AlekSi enabled auto-merge (squash) May 12, 2023 06:25
@AlekSi AlekSi disabled auto-merge May 12, 2023 06:38
@AlekSi AlekSi merged commit 9249bc4 into FerretDB:main May 12, 2023
@AlekSi
Copy link
Member

AlekSi commented May 12, 2023

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlekSi AlekSi AlekSi approved these changes

@rumyantseva rumyantseva Awaiting requested review from rumyantseva rumyantseva was automatically assigned from FerretDB/leads

@chilagrow chilagrow Awaiting requested review from chilagrow

Assignees

@AlekSi AlekSi

@wqhhust wqhhust

Labels
code/chore Code maintenance improvements
Projects
Current Engineering
Archived in project
Milestone
v1.2.0
Development

Successfully merging this pull request may close these issues.

Cleanup old Docker images
3 participants
@wqhhust @AlekSi @chilagrow