Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move handlers/pg/pjson to handlers/sjson #2531

Merged
merged 3 commits into from
Apr 30, 2023
Merged

Move handlers/pg/pjson to handlers/sjson #2531

merged 3 commits into from
Apr 30, 2023

Conversation

craigpastro
Copy link
Contributor

Description

Closes #2495. A part of #2387. Excited for SQLite ❤️

Readiness checklist

  • I added/updated unit tests.
  • I added/updated integration/compatibility tests.
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@craigpastro craigpastro requested review from a team and AlekSi as code owners April 28, 2023 17:00
@craigpastro craigpastro requested a review from w84thesun April 28, 2023 17:00
@mergify
Copy link
Contributor

mergify bot commented Apr 28, 2023

@craigpastro this pull request has merge conflicts.

@mergify mergify bot added the conflict PRs that have merge conflicts label Apr 28, 2023
@mergify mergify bot removed the conflict PRs that have merge conflicts label Apr 28, 2023
@codecov
Copy link

codecov bot commented Apr 28, 2023 •
edited
Loading

Codecov Report

Merging #2531 (bf17c0a) into main (9b05371) will increase coverage by 0.00%.
The diff coverage is 58.69%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2531   +/-   ##
=======================================
  Coverage   64.35%   64.36%           
=======================================
  Files         403      403           
  Lines       20029    20031    +2     
=======================================
+ Hits        12890    12892    +2     
  Misses       6204     6204           
  Partials      935      935
Impacted Files Coverage Δ
internal/handlers/sjson/binary.go 70.96% <0.00%> (ø)
internal/handlers/sjson/bool.go 47.82% <0.00%> (ø)
internal/handlers/sjson/datetime.go 57.69% <0.00%> (ø)
internal/handlers/sjson/int32.go 47.82% <0.00%> (ø)
internal/handlers/sjson/int64.go 62.50% <0.00%> (ø)
internal/handlers/sjson/null.go 40.00% <0.00%> (ø)
internal/handlers/sjson/object_id.go 51.61% <0.00%> (ø)
internal/handlers/sjson/regex.go 70.00% <0.00%> (ø)
internal/handlers/sjson/schema.go 83.78% <0.00%> (ø)
internal/handlers/sjson/string.go 47.82% <0.00%> (ø)
... and 13 more

... and 1 file with indirect coverage changes

Flag Coverage Δ
integration 57.18% <45.65%> (+<0.01%) ⬆️
mongodb 5.05% <0.00%> (-0.01%) ⬇️
pg 57.11% <45.65%> (+<0.01%) ⬆️
unit 25.64% <54.34%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

w84thesun
w84thesun previously approved these changes Apr 28, 2023
View reviewed changes
Copy link
Contributor

@w84thesun w84thesun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution! That change will make us closer to SQLite backend support!

@w84thesun w84thesun enabled auto-merge (squash) April 28, 2023 23:11
@w84thesun w84thesun added the code/chore Code maintenance improvements label Apr 28, 2023
@ptrfarkas ptrfarkas requested review from rumyantseva and removed request for AlekSi April 28, 2023 23:52
rumyantseva
rumyantseva previously approved these changes Apr 29, 2023
View reviewed changes
Copy link
Contributor

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for your contribution! Very neat approach to identifying all the pjson places!

I left one minor comment, but overall the PR looks good to me!

.golangci.yml Show resolved Hide resolved
@rumyantseva rumyantseva changed the title Move handlers/pg/pjson to handlers/sjson Move handlers/pg/pjson to handlers/sjson Apr 29, 2023
auto-merge was automatically disabled April 29, 2023 19:16

Head branch was pushed to by a user without write access

@craigpastro craigpastro dismissed stale reviews from rumyantseva and w84thesun via bf17c0a April 29, 2023 19:16
@w84thesun w84thesun requested a review from rumyantseva April 29, 2023 22:33
@w84thesun w84thesun enabled auto-merge (squash) April 29, 2023 22:33
rumyantseva
rumyantseva approved these changes Apr 30, 2023
View reviewed changes
Copy link
Contributor

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@w84thesun w84thesun merged commit 6e0bd57 into FerretDB:main Apr 30, 2023
@craigpastro craigpastro deleted the move-pjson-to-sjson branch April 30, 2023 13:12
@AlekSi AlekSi added this to the v1.1.0 milestone May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rumyantseva rumyantseva rumyantseva approved these changes

@w84thesun w84thesun w84thesun approved these changes

Assignees

@craigpastro craigpastro

Labels
code/chore Code maintenance improvements
Projects
Current Engineering
Archived in project
Milestone
v1.1.0
Development

Successfully merging this pull request may close these issues.

Move handlers/pg/pjson to handlers/sjson
4 participants
@craigpastro @w84thesun @rumyantseva @AlekSi